From: Damien Le Moal <dlemoal@kernel.org>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v5 3/5] null_blk: replace null_process_cmd() call in null_zone_write()
Date: Thu, 30 Jan 2025 11:36:03 +0900 [thread overview]
Message-ID: <fee0cec3-bc9f-4902-bc8a-dbc93da9ff71@kernel.org> (raw)
In-Reply-To: <20250125012908.1259887-4-shinichiro.kawasaki@wdc.com>
On 1/25/25 10:29, Shin'ichiro Kawasaki wrote:
> As a preparation to support partial data transfer by badblocks, replace
s/by/due to/
> the null_process_cmd() call in null_zone_write() with equivalent calls
> to null_handle_badblocks() and null_handle_memory_backed(). This commit
> does not change behavior. It enables null_handle_badblocks() to return
Since this patch does not yet do this, maybe rephrase this to:
It will enable null_handle_badblocks() to return...
> the size of partial data transfer in the following commit, allowing
> null_zone_write() to move write pointers appropriately.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
With this fixed,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-01-30 2:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-25 1:29 [PATCH v5 0/5] null_blk: improve write failure simulation Shin'ichiro Kawasaki
2025-01-25 1:29 ` [PATCH v5 1/5] null_blk: generate null_blk configfs features string Shin'ichiro Kawasaki
2025-01-25 1:29 ` [PATCH v5 2/5] null_blk: introduce badblocks_once parameter Shin'ichiro Kawasaki
2025-01-25 1:29 ` [PATCH v5 3/5] null_blk: replace null_process_cmd() call in null_zone_write() Shin'ichiro Kawasaki
2025-01-30 2:36 ` Damien Le Moal [this message]
2025-01-25 1:29 ` [PATCH v5 4/5] null_blk: pass transfer size to null_handle_rq() Shin'ichiro Kawasaki
2025-01-25 1:29 ` [PATCH v5 5/5] null_blk: do partial IO for bad blocks Shin'ichiro Kawasaki
2025-01-27 9:20 ` [PATCH v5 0/5] null_blk: improve write failure simulation Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee0cec3-bc9f-4902-bc8a-dbc93da9ff71@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).