From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794564705; b=JL/ps1F0/br7utfnEghij5Z1g+s0vpAQUBJqp+FFRJpBHP7xFjwLz+svYTuGLXsVZMup XoBESimkFRjuLU9e3cRE7MhSOj5MU0phUyUCeYq5bPSBOEHfe3+0yLo2vBv7LiQuUCt70 CU0L5pgupW7MDURawkZUv7JYpQ0Dxu1876zq92X2ks3OP/mSFXfGV+O7Z0RK8XrZAEyDg CJXOhI7b+fdxAqh4zmS0HlmwJ2znt96H7+21zzjDoyR263lo2+gEHoQbgvfAAm7QxEZrA xAIrxzGlu5omewOV1sTRhnvfEnaQ9A9UgqGjHjfVWT61SPZ1uoDZr7CUk2p5G3Dvu2g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794564705; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=gXMsjTg9KyNTuX1cuQ9yr2iJq2/VClhNCtHhh+FL0ZU=; b=KmUcMYQcQ++l+fSA+HSUVFrkU7Bd9dbqSxutXprjIqcILrP8R/urDg05xNIE4LhXAeNE 15kME5O3Nk1783mKBT7GEi+HLLm5QscXVcttcxEa/Sseq9zdhBawZigH1OEqo7fROFctF vUxTaZP4GfK2i0UPQ4iuSLAeY5xUZF5xiHkaFkzqMvKiZ77Ld9/7kQ6AMI4PPWW9fJK4q 6lrAXfJDYaVkpM2DZ5TqhOHxVPxqICj0hsOXCml5+XhUJC4gBB/g2SworGGJAcPivUxJY 3/sNSno7Gv0FLDIj/6N9Y0bZlHrwXSTwTkOa6z0Tv0gxc5y3pFFEexFnjY4TnDWRGfA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=amutable.com; spf=pass smtp.mailfrom=amutable.com; dkim=pass header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=BADxd+iU; arc=none smtp.remote-ip=209.85.221.45 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98C33606B11B for ; Fri, 13 Nov 2026 10:11:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 98C33606B11B Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amutable.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=BADxd+iU Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-492fcbfaa88so323604f8f.3 for ; Fri, 13 Nov 2026 02:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794564703; x=1795169503; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=gXMsjTg9KyNTuX1cuQ9yr2iJq2/VClhNCtHhh+FL0ZU=; b=BADxd+iUI5Bylfm9xHmZjb4pgHg0fbyWkyp8vNCt747iYknkt4pGGRNYLQ78EH/z4x Vbi/Jq3+E8iOs58TJRk6WPlWSpFf2OpeZbjgHeXjXzKeHm9XnJ+eEvU2VLt6liCBRq7I 79Td6VY4SiSTAXWOIivpd5ztVkC+DBAB/J4OfHn49+YeU7s/KQ9yNfnwb8sPZOTKoGu0 Zirp8LScbJznGaQAXzatlGuiy/pBfqScnET/jGobuhYjlwMbyAqyeVJ7smTe1nJkO+dB h89eeA8CIS4pNdPKyjqDo55n+EKX5qBSzrC2C/95dZzzzQLBvHRJ+46c+P8Bzg/7r93a +u0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794564703; x=1795169503; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gXMsjTg9KyNTuX1cuQ9yr2iJq2/VClhNCtHhh+FL0ZU=; b=GN54ETtCVp/4ac7JRM4sDKdWnAw27Q+VwJ9BXTsJBhpFGCP3s51OO4V5MrZigKLKNi ij8/CVnUCqNUrWMTV1aX4dhRLiU+kxaQdXRiX5lZGv3D9yvoyvSjBhpPvExyVfnqNzpG DtxlmvL+Ex95U2aociKHqKZg9h592SiY/8Zy4qsNAOz3xd3J9NIF7YMaZyAVhX4oCkr8 WoxF9/adrtEl/tEP7rN8si85qAngSiTvKYruMLZjSwO4/k89bKp0VkE3QhriaOaimw2f MvDWnsKJSDMxgKyv785Qq0UnVEhhpI1lwfokHVwOQksOjDdvFdd+4ePhoPx91zHMmbiI tCdw== X-Forwarded-Encrypted: i=1; AL+hErH4o/HtB27ssq+n68v6W0QLaGXH+zi6Wh2++y8CK1bmJZF/AlR5akpCiX0EfPY0DpDvSZZtlwYtLwK/nQ==@vger.kernel.org X-Gm-Message-State: APuU4Z9Yh6sZvKcE5ovJXaO72JtBgr6v+BV6+3fUWdCEHYfPH4cCIhl5 XjrAObOqF/QB86wfhllXU1E11ORY8dlZbb8VuiOBB6JSSCPrtYRa7AtCw20rPBwBd6S2 X-Gm-Gg: AYBFou1LpXRkm264fNlHJ0/TQMdzJF6CTzaIhWzmsv95SsFvw+Baygcv89E6JyJrEYf 8692v3DNgx0T7gv0ECtpstQiiw+wcFkXyDw8CbDFkQOAkLsXTyPmfLoEAm6XDMBegl+NE4RpgES sSzkXGxzhqXbQaZrua218G9LtAxEifDKW9ru5K6WCu4EMVJlTWM4NIp/zi0shVVUNEbiQh0m20k HgqyK5G3c0PWAbcoaXvknaB6zTyHRAQ8JPo9a8DJpYOU1JvufYfSPW6wlAVpLHHDw1Vt0WqiLd6 AVFYBw/BwvZVKOoS/fm6iqqYXVBOnTexkPC8F2xmo+EoE0QxgPFfmL/y5C0e7Opq8ePLlLtj/jK CJgVfCMGoHc2UHvTT7ivLnjsBoCDH5AzORdK9FZJPJDjFWupZkDHf2GPOpWk3YfvX/G8OgAs2Jq hcs3mdongiYJ1tNq4ku64F23+4uCff/+LK+Cqrc5znY+TnT4ji4N6hbp0RIL52NTp3ejkE4uFwC 6o3Cqe9MxWC/YU9Br49NVcoTMKlxaYRtLh0yeqp2USzKI5M8y+a3/ANhCQ0o884g94EOHbczf0d 7ETAl6SgSMyy6CqO6MX+IJIAV67cQcF4XddGKZH41pCFfm48bMXRCS18u4BKCss= X-Received: by 2002:a05:6000:2501:b0:488:88ec:59c3 with SMTP id ffacd0b85a97d-49c73259cc3mr5012611f8f.14.1794564703010; Fri, 13 Nov 2026 02:11:43 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c5f1c1797sm4931434f8f.11.2026.11.13.02.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 02:11:42 -0800 (PST) Message-ID: Subject: Re: [PATCH RFC 18/41] selinux: use fc_init_pseudo() for selinuxfs From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org Date: Fri, 13 Nov 2026 11:11:40 +0100 In-Reply-To: <20261110-work-loop-pseudo-v1-18-4c998976c6c7@kernel.org> References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-18-4c998976c6c7@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote: > Initialize selinuxfs as a pseudo filesystem. This raises SB_I_PSEUDO > and > SB_I_NOEXEC. selinuxfs never holds executables. SB_I_NOEXEC also > refuses PROT_EXEC mappings but the status and policy files are only > ever mapped for reading. >=20 > But selinuxfs needs device nodes. The kernel replaces file > descriptors > with /sys/fs/selinux/null on exec via dentry_open() which doesn't > care > about SB_I_NODEV. Android init however opens /sys/fs/selinux/null by > path as /dev/null doesn't exist yet at that point. So clear > SB_I_NODEV > again in sel_fill_super(). >=20 > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn I.=20 > --- > =C2=A0security/selinux/selinuxfs.c | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/security/selinux/selinuxfs.c > b/security/selinux/selinuxfs.c > index 310e19efff1d..d7ae853b6d68 100644 > --- a/security/selinux/selinuxfs.c > +++ b/security/selinux/selinuxfs.c > @@ -18,6 +18,7 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include > +#include > =C2=A0#include > =C2=A0#include > =C2=A0#include > @@ -1852,6 +1853,9 @@ static int sel_fill_super(struct super_block > *sb, struct fs_context *fc) > =C2=A0 /* last one */ {"", NULL, 0} > =C2=A0 }; > =C2=A0 > + /* Android init opens the null device below by path. */ > + sb->s_iflags &=3D ~SB_I_NODEV; > + > =C2=A0 ret =3D selinux_fs_info_create(sb); > =C2=A0 if (ret) > =C2=A0 goto err; > @@ -1955,6 +1959,7 @@ static const struct fs_context_operations > sel_context_ops =3D { > =C2=A0 > =C2=A0static int sel_init_fs_context(struct fs_context *fc) > =C2=A0{ > + fc_init_pseudo(fc); > =C2=A0 fc->ops =3D &sel_context_ops; > =C2=A0 return 0; > =C2=A0}