From: Johannes Thumshirn <jthumshirn@suse.de>
To: xiao yang <yangx.jy@cn.fujitsu.com>
Cc: <osandov@osandov.com>, <eguan@redhat.com>,
<fstests@vger.kernel.org>, <linux-block@vger.kernel.org>
Subject: Re: [PATCH blktests] block/013: Add test for BLKRRPART ioctl
Date: Tue, 19 Dec 2017 11:47:09 +0100 [thread overview]
Message-ID: <mqd8tdzataq.fsf@linux-x5ow.site> (raw)
In-Reply-To: <1513679423-13067-1-git-send-email-yangx.jy@cn.fujitsu.com> (xiao yang's message of "Tue, 19 Dec 2017 18:30:23 +0800")
xiao yang <yangx.jy@cn.fujitsu.com> writes:
> +requires() {
> + _have_program mkfs.ext3
> +}
[...]
> + # Format
> + mkfs.ext3 -F "$TEST_DEV" >> "$FULL" 2>&1
What's the reason to limit the test case to ext3 only? Can you switch it
to the generic 'mkfs' command? IIRC we require 'util-linux' to be
present for blktests but mkfs.ext3 is (at least in SUSE based distros)
in the e2fsprogs package.
apart from that:
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-12-19 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1511956946-16667-1-git-send-email-yangx.jy@cn.fujitsu.com>
2017-12-04 8:29 ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Eryu Guan
2017-12-04 9:15 ` Xiao Yang
2017-12-04 9:25 ` Eryu Guan
2017-12-04 9:48 ` Xiao Yang
2017-12-04 18:29 ` Omar Sandoval
2017-12-19 10:30 ` [PATCH blktests] block/013: Add test for BLKRRPART ioctl xiao yang
2017-12-19 10:47 ` Johannes Thumshirn [this message]
2017-12-19 19:42 ` Omar Sandoval
2017-12-20 8:03 ` Johannes Thumshirn
2017-12-19 23:42 ` Omar Sandoval
2017-12-19 10:45 ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Xiao Yang
2017-12-19 10:53 ` Johannes Thumshirn
2017-12-19 10:59 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqd8tdzataq.fsf@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
--cc=yangx.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox