* Re: [PATCH 01/25] bdi: Provide bdi_register_va() and bdi_alloc()
From: Christoph Hellwig @ 2017-04-12 8:06 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-2-jack@suse.cz>
Normally this would be two separate patches.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 02/25] block: Unregister bdi on last reference drop
From: Christoph Hellwig @ 2017-04-12 8:06 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-3-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 03/25] bdi: Export bdi_alloc_node() and bdi_put()
From: Christoph Hellwig @ 2017-04-12 8:08 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-4-jack@suse.cz>
On Wed, Mar 29, 2017 at 12:56:01PM +0200, Jan Kara wrote:
> MTD will want to call bdi_alloc_node() and bdi_put() directly. Export
> these functions.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 04/25] fs: Provide infrastructure for dynamic BDIs in filesystems
From: Christoph Hellwig @ 2017-04-12 8:09 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, linux-mtd,
linux-nfs, Petr Vandrovec, linux-nilfs, cluster-devel, osd-dev,
codalist, linux-afs, ecryptfs, linux-cifs, ceph-devel,
linux-btrfs, v9fs-developer, lustre-devel
In-Reply-To: <20170329105623.18241-5-jack@suse.cz>
> + if (sb->s_iflags & SB_I_DYNBDI) {
> + bdi_put(sb->s_bdi);
> + sb->s_bdi = &noop_backing_dev_info;
At some point I'd really like to get rid of noop_backing_dev_info and
have a NULL here..
Otherwise this looks fine..
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 05/25] fs: Get proper reference for s_bdi
From: Christoph Hellwig @ 2017-04-12 8:09 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-6-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 06/25] lustre: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:10 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Oleg Drokin,
Andreas Dilger, James Simmons, lustre-devel
In-Reply-To: <20170329105623.18241-7-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 07/25] 9p: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:10 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig,
Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov,
v9fs-developer
In-Reply-To: <20170329105623.18241-8-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 08/25] btrfs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:10 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Chris Mason,
Josef Bacik, David Sterba, linux-btrfs
In-Reply-To: <20170329105623.18241-9-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 09/25] ceph: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:11 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Ilya Dryomov,
Yan, Zheng, Sage Weil, ceph-devel
In-Reply-To: <20170329105623.18241-10-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 10/25] cifs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:11 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Steve French,
linux-cifs
In-Reply-To: <20170329105623.18241-11-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 11/25] ecryptfs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:11 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Tyler Hicks,
ecryptfs
In-Reply-To: <20170329105623.18241-12-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 12/25] afs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:12 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, David Howells,
linux-afs
In-Reply-To: <20170329105623.18241-13-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 13/25] mtd: Convert to dynamically allocated bdi infrastructure
From: Christoph Hellwig @ 2017-04-12 8:14 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, David Woodhouse,
Brian Norris, linux-mtd
In-Reply-To: <20170329105623.18241-14-jack@suse.cz>
> + sb->s_bdi = bdi_get(mtd_bdi);
> + sb->s_iflags |= SB_I_DYNBDI;
FTI, while I think this is a faithful conversion of the existing code,
the single bdi for all MTD devices looks rather bogus to me..
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 14/25] coda: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:14 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Jan Harkes, coda,
codalist
In-Reply-To: <20170329105623.18241-15-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 15/25] exofs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:14 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Boaz Harrosh,
Benny Halevy
In-Reply-To: <20170329105623.18241-16-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 16/25] fuse: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:15 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig, Miklos Szeredi
In-Reply-To: <20170329105623.18241-17-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 17/25] fuse: Get rid of bdi_initialized
From: Christoph Hellwig @ 2017-04-12 8:15 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig, Miklos Szeredi
In-Reply-To: <20170329105623.18241-18-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 18/25] gfs2: Convert to properly refcounting bdi
From: Christoph Hellwig @ 2017-04-12 8:16 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Steven Whitehouse,
Bob Peterson, cluster-devel
In-Reply-To: <20170329105623.18241-19-jack@suse.cz>
On Wed, Mar 29, 2017 at 12:56:16PM +0200, Jan Kara wrote:
> Similarly to set_bdev_super() GFS2 just used block device reference to
> bdi. Convert it to properly getting bdi reference. The reference will
> get automatically dropped on superblock destruction.
Hmm, why iisn't gfs2 simply using the generic mount_bdev code?
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 19/25] nilfs2: Convert to properly refcounting bdi
From: Christoph Hellwig @ 2017-04-12 8:17 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Ryusuke Konishi,
linux-nilfs
In-Reply-To: <20170329105623.18241-20-jack@suse.cz>
On Wed, Mar 29, 2017 at 12:56:17PM +0200, Jan Kara wrote:
> Similarly to set_bdev_super() NILFS2 just used block device reference to
> bdi. Convert it to properly getting bdi reference. The reference will
> get automatically dropped on superblock destruction.
I really wish we could get rid of this open coding in block based
file systems..
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 20/25] ncpfs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:18 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig, Petr Vandrovec
In-Reply-To: <20170329105623.18241-21-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 21/25] nfs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:20 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Trond Myklebust,
Anna Schumaker, linux-nfs
In-Reply-To: <20170329105623.18241-22-jack@suse.cz>
> /*
> * Finish setting up an NFS2/3 superblock
> */
I was just looking why you didn't update the v4 variant, but it seems
like the comment above is simply incorrect..
Thus the patch looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 22/25] ubifs: Convert to separately allocated bdi
From: Christoph Hellwig @ 2017-04-12 8:20 UTC (permalink / raw)
To: Jan Kara
Cc: linux-fsdevel, linux-block, Christoph Hellwig, Richard Weinberger,
Artem Bityutskiy, Adrian Hunter, linux-mtd
In-Reply-To: <20170329105623.18241-23-jack@suse.cz>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 23/25] fs: Remove SB_I_DYNBDI flag
From: Christoph Hellwig @ 2017-04-12 8:21 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-24-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 24/25] block: Remove unused functions
From: Christoph Hellwig @ 2017-04-12 8:21 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-25-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
* Re: [PATCH 25/25] bdi: Drop 'parent' argument from bdi_register[_va]()
From: Christoph Hellwig @ 2017-04-12 8:21 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, linux-block, Christoph Hellwig
In-Reply-To: <20170329105623.18241-26-jack@suse.cz>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox