* Re: [PATCH V4 3/9] null_blk: move unregister_blkdev() after destroying dev in null_exit()
From: Nilay Shroff @ 2026-07-10 12:36 UTC (permalink / raw)
To: Zizhi Wo, axboe, dlemoal, kch, johannes.thumshirn, kbusch,
bvanassche, linux-block
Cc: linux-kernel, yangerkun, chengzhihao1, wozizhi
In-Reply-To: <20260709100452.3520482-4-wozizhi@huaweicloud.com>
On 7/9/26 3:34 PM, Zizhi Wo wrote:
> In null_exit(), unregister_blkdev() is called before the null_blk instances
> are destroyed, which is inconsistent with the cleanup order in null_init().
> Move it after null_destroy_dev() so that teardown happens in the reverse
> order of initialization.
>
> No functional change intended.
Looks good to me.
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
^ permalink raw reply
* Re: [PATCH v2] xen-blkfront: fix double completion of split requests on resume
From: Jens Axboe @ 2026-07-10 12:49 UTC (permalink / raw)
To: Roger Pau Monné, Juergen Gross, Doruk Tan Ozturk
Cc: Stefano Stabellini, Oleksandr Tyshchenko, xen-devel, linux-block,
linux-kernel
In-Reply-To: <20260709100853.7489-1-doruk@0sec.ai>
On Thu, 09 Jul 2026 12:08:53 +0200, Doruk Tan Ozturk wrote:
> When a block request is too large for a single ring entry and the
> backend does not support indirect descriptors, blkfront splits it across
> two ring requests. This only happens when the frontend runs on a
> 64K-page kernel (e.g. arm64): there, even a single-page request may not
> fit in one ring slot and must be split. blkif_ring_get_request() is
> called twice and both shadow slots (shadow[id] and shadow[extra_id])
> point at the *same* struct request, linked through associated_id.
>
> [...]
Applied, thanks!
[1/1] xen-blkfront: fix double completion of split requests on resume
commit: 5d72720365f973e2c21fa99505b627521de66c25
Best regards,
--
Jens Axboe
^ permalink raw reply
* Re: [PATCH V4 6/9] null_blk: clean up null_del_dev() to use cached dev pointer
From: Nilay Shroff @ 2026-07-10 13:03 UTC (permalink / raw)
To: Zizhi Wo, axboe, dlemoal, kch, johannes.thumshirn, kbusch,
bvanassche, linux-block
Cc: linux-kernel, yangerkun, chengzhihao1, wozizhi
In-Reply-To: <20260709100452.3520482-7-wozizhi@huaweicloud.com>
On 7/9/26 3:34 PM, Zizhi Wo wrote:
> Replace remaining nullb->dev dereferences with the already-cached
> local dev variable. No functional change.
>
> Signed-off-by: Zizhi Wo<wozizhi@huawei.com>
Looks good to me.
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
^ permalink raw reply
page: | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).