From: Jeff Moyer <jmoyer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/5] blk-mq: update ->init_request and ->exit_request prototypes
Date: Fri, 28 Apr 2017 10:27:50 -0400 [thread overview]
Message-ID: <x494lx8r4ih.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20170428140923.GA32073@lst.de> (Christoph Hellwig's message of "Fri, 28 Apr 2017 16:09:23 +0200")
Christoph Hellwig <hch@lst.de> writes:
>> If you got rid of request_idx, then this shouldn't build. So, is there
>> some other prerequisite patch I'm missing?
>
> Yes, both you and I are. It's "mtip32xx: use runtime tag to initialize
> command header" which is in Jens' for-4.12/block tree, but not in the
> post-merge one.
I see. With that patch, my concern about walking off the end of the
array is addressed. Thanks.
-Jeff
next prev parent reply other threads:[~2017-04-28 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 17:44 update ->init_request and ->exit_request prototypes Christoph Hellwig
2017-04-27 17:44 ` [PATCH 1/5] blk-mq: " Christoph Hellwig
2017-04-27 18:20 ` Jeff Moyer
2017-04-28 14:09 ` Christoph Hellwig
2017-04-28 14:19 ` Jens Axboe
2017-04-28 14:20 ` Jens Axboe
2017-04-28 14:24 ` Christoph Hellwig
2017-04-28 14:27 ` Jeff Moyer [this message]
2017-04-27 17:44 ` [PATCH 2/5] nvme-pci: merge init_request methods Christoph Hellwig
2017-04-27 17:44 ` [PATCH 3/5] nvme-rdma: merge init_request and exit_request methods Christoph Hellwig
2017-04-27 17:45 ` [PATCH 4/5] nvme-fc: merge init_request methods Christoph Hellwig
2017-04-27 17:45 ` [PATCH 5/5] nvme-loop: " Christoph Hellwig
2017-04-28 14:53 ` update ->init_request and ->exit_request prototypes Christoph Hellwig
2017-05-03 7:53 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x494lx8r4ih.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).