From: Jeff Moyer <jmoyer@redhat.com>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>, Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ulf.hansson@linaro.org, linus.walleij@linaro.org,
broonie@kernel.org
Subject: Re: [PATCH BUGFIX] block: add missing group association in bio_split
Date: Tue, 10 May 2016 12:12:39 -0400 [thread overview]
Message-ID: <x4960ul7uyw.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1462871322-13217-1-git-send-email-paolo.valente@linaro.org> (Paolo Valente's message of "Tue, 10 May 2016 11:08:42 +0200")
Paolo Valente <paolo.valente@linaro.org> writes:
> When a bio is split, the newly created bio must be associated with the
> same blkcg as the original bio (if BLK_CGROUP is enabled). If this
> operation is not performed, then the new bio is not associated with
> any group, and the group of the current task is returned when the
> group of the bio is requested.
>
> Depending on the frequency of splits, this may cause a large
> percentage of the bios belonging to a given group to be treated as if
> belonging to other groups (in most cases as if belonging to the root
> group). The expected group isolation may thereby be then broken.
>
> This commit adds the missing association in bio_split.
>
> Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
> ---
> block/bio.c | 15 +++++++++++++++
> include/linux/bio.h | 2 ++
> 2 files changed, 17 insertions(+)
>
> diff --git a/block/bio.c b/block/bio.c
> index 807d25e..20795eb 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1811,6 +1811,8 @@ struct bio *bio_split(struct bio *bio, int sectors,
>
> bio_advance(bio, split->bi_iter.bi_size);
>
> + bio_clone_blkcg_association(split, bio);
> +
First, I think this should be done inside of bio_clone_fast and
bio_clone_bioset instead of in bio_split. Otherwise you miss other
places where bios are cloned, and I'm guessing that's bad. You could
also then get rid of this code in btrfs/extent_io.c:
#ifdef CONFIG_BLK_CGROUP
/* FIXME, put this into bio_clone_bioset */
if (bio->bi_css)
bio_associate_blkcg(new, bio->bi_css);
#endif
Next, you went to the trouble of propagating the return value from
bio_associate_blkcg, and then it goes unchecked here in the only caller
of your new function. Since bio_associate_blkcg should not fail when
cloning (right?), I'd change bio_clone_blkcg_association to return void
and to WARN_ON a failure return from bio_associate_blkcg.
Cheers,
Jeff
> return split;
> }
> EXPORT_SYMBOL(bio_split);
> @@ -2016,6 +2018,19 @@ void bio_disassociate_task(struct bio *bio)
> }
> }
>
> +/**
> + * bio_clone_blkcg_association - clone blkcg association from src to dst bio
> + * @dst: destination bio
> + * @src: source bio
> + */
> +int bio_clone_blkcg_association(struct bio *dst, struct bio *src)
> +{
> + if (src->bi_css)
> + return bio_associate_blkcg(dst, src->bi_css);
> +
> + return 0;
> +}
> +
> #endif /* CONFIG_BLK_CGROUP */
>
> static void __init biovec_init_slabs(void)
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 6b7481f..8535f81 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -527,11 +527,13 @@ extern unsigned int bvec_nr_vecs(unsigned short idx);
> int bio_associate_blkcg(struct bio *bio, struct cgroup_subsys_state *blkcg_css);
> int bio_associate_current(struct bio *bio);
> void bio_disassociate_task(struct bio *bio);
> +int bio_clone_blkcg_association(struct bio *dst, struct bio *src);
> #else /* CONFIG_BLK_CGROUP */
> static inline int bio_associate_blkcg(struct bio *bio,
> struct cgroup_subsys_state *blkcg_css) { return 0; }
> static inline int bio_associate_current(struct bio *bio) { return -ENOENT; }
> static inline void bio_disassociate_task(struct bio *bio) { }
> +int bio_clone_blkcg_association(struct bio *dst, struct bio *src) { return 0; }
> #endif /* CONFIG_BLK_CGROUP */
>
> #ifdef CONFIG_HIGHMEM
next prev parent reply other threads:[~2016-05-10 16:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 20:45 [PATCH BUGFIX] block: add missing group association in bio_split Paolo Valente
2016-05-09 14:19 ` Jeff Moyer
2016-05-09 14:35 ` Jeff Moyer
2016-05-09 14:39 ` Paolo
2016-05-09 14:55 ` Jens Axboe
2016-05-09 14:56 ` Mark Brown
2016-05-09 17:58 ` Jens Axboe
2016-05-10 9:08 ` Paolo Valente
2016-05-10 16:12 ` Jeff Moyer [this message]
2016-05-10 17:08 ` Paolo
2016-05-10 20:23 ` [PATCH BUGFIX] block: add missing group association in bio-cloning functions Paolo Valente
2016-05-10 20:44 ` Tejun Heo
2016-05-10 21:02 ` [PATCH BUGFIX V2] " Paolo Valente
2016-05-10 21:03 ` Tejun Heo
2016-05-10 21:34 ` Jeff Moyer
2016-05-10 21:44 ` Paolo
2016-05-10 22:01 ` [PATCH BUGFIX V3] " Paolo Valente
2016-05-11 6:38 ` Nikolay Borisov
2016-05-11 6:43 ` Nikolay Borisov
2016-05-11 9:06 ` Paolo
2016-05-11 9:28 ` [PATCH BUGFIX V4] " Paolo Valente
2016-05-12 15:10 ` Tejun Heo
2016-05-13 20:42 ` Jeff Moyer
2016-06-07 7:09 ` Paolo
2016-07-26 16:14 ` Paolo Valente
2016-07-26 17:01 ` kbuild test robot
2016-07-27 5:22 ` [PATCH BUGFIX V5] " Paolo Valente
2016-07-27 14:45 ` Jens Axboe
2016-05-09 15:20 ` [PATCH BUGFIX] block: add missing group association in bio_split Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x4960ul7uyw.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).