From: Jeff Moyer <jmoyer@redhat.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
Shaun Tancheff <shaun@tancheff.com>,
Damien Le Moal <damien.lemoal@hgst.com>
Subject: Re: [PATCH v8 6/7] sd: Implement support for ZBC devices
Date: Tue, 18 Oct 2016 12:58:11 -0400 [thread overview]
Message-ID: <x498ttlvbks.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1476772835-18541-7-git-send-email-damien.lemoal@wdc.com> (Damien Le Moal's message of "Tue, 18 Oct 2016 15:40:34 +0900")
Damien Le Moal <damien.lemoal@wdc.com> writes:
> + if (!is_power_of_2(zone_blocks)) {
> + if (sdkp->first_scan)
> + sd_printk(KERN_NOTICE, sdkp,
> + "Devices with non power of 2 zone "
> + "size are not supported\n");
> + return -ENODEV;
> + }
Are power of 2 zone sizes required by the standard? I see why you've
done this, but I wonder if we're artificially limiting the
implementation, and whether there will be valid devices on the market
that simply won't work with Linux because of this.
-Jeff
next prev parent reply other threads:[~2016-10-18 16:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 6:40 [PATCH v8 0/7] ZBC / Zoned block device support Damien Le Moal
2016-10-18 6:40 ` [PATCH v8 1/7] block: Add 'zoned' queue limit Damien Le Moal
2016-10-18 6:42 ` Hannes Reinecke
2016-10-18 6:40 ` [PATCH v8 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Damien Le Moal
2016-10-18 16:43 ` Jeff Moyer
2016-10-18 23:17 ` Damien Le Moal
2016-10-18 6:40 ` [PATCH v8 3/7] block: update chunk_sectors in blk_stack_limits() Damien Le Moal
2016-10-18 6:40 ` [PATCH v8 4/7] block: Define zoned block device operations Damien Le Moal
2016-10-18 6:40 ` [PATCH v8 5/7] block: Implement support for zoned block devices Damien Le Moal
2016-10-18 6:40 ` [PATCH v8 6/7] sd: Implement support for ZBC devices Damien Le Moal
2016-10-18 16:58 ` Jeff Moyer [this message]
2016-10-18 18:22 ` Shaun Tancheff
2016-10-19 13:23 ` Jeff Moyer
2016-10-19 0:44 ` Martin K. Petersen
2016-10-19 13:21 ` Jeff Moyer
2016-10-19 0:47 ` Martin K. Petersen
2016-10-18 6:40 ` [PATCH v8 7/7] blk-zoned: implement ioctls Damien Le Moal
2016-10-18 15:58 ` [PATCH v8 0/7] ZBC / Zoned block device support Jens Axboe
2016-10-18 23:15 ` Damien Le Moal
2016-10-19 0:46 ` Martin K. Petersen
2016-10-19 1:49 ` Jens Axboe
2016-10-19 1:53 ` Martin K. Petersen
2016-10-19 1:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x498ttlvbks.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@hgst.com \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun@tancheff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).