From: Jeff Moyer <jmoyer@redhat.com>
To: Shaohua Li <shli@fb.com>
Cc: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, <axboe@fb.com>,
<Kernel-team@fb.com>
Subject: Re: [PATCH 2/3] blktrace: add missed mask name
Date: Tue, 10 May 2016 11:45:47 -0400 [thread overview]
Message-ID: <x49eg997w7o.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <ea5ffed7a013bf524d3576cdff8ad00d11a68bf2.1462838969.git.shli@fb.com> (Shaohua Li's message of "Mon, 9 May 2016 17:22:14 -0700")
Shaohua Li <shli@fb.com> writes:
> BLK_TC_NOTIFY is missed in mask_maps, so we can't print out notify or
> set mask with 'notify' name.
For the text-based interface, yeah.
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
> kernel/trace/blktrace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index 8ae9ea2..9aef865 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -1552,6 +1552,7 @@ static const struct {
> { BLK_TC_COMPLETE, "complete" },
> { BLK_TC_FS, "fs" },
> { BLK_TC_PC, "pc" },
> + { BLK_TC_NOTIFY, "notify" },
> { BLK_TC_AHEAD, "ahead" },
> { BLK_TC_META, "meta" },
> { BLK_TC_DISCARD, "discard" },
next prev parent reply other threads:[~2016-05-10 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 0:22 [PATCH 1/3] blktrace: delete garbage for message trace Shaohua Li
2016-05-10 0:22 ` [PATCH 2/3] blktrace: add missed mask name Shaohua Li
2016-05-10 15:45 ` Jeff Moyer [this message]
2016-05-10 0:22 ` [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled Shaohua Li
2016-05-10 5:46 ` Simon Guo
2016-05-11 16:54 ` Shaohua Li
2016-05-10 15:52 ` Jeff Moyer
2016-05-10 23:33 ` Steven Rostedt
2016-05-11 13:47 ` Jeff Moyer
2016-05-11 0:20 ` Shaohua Li
2016-05-11 13:41 ` Jeff Moyer
2016-05-11 16:49 ` Shaohua Li
2016-05-10 14:31 ` [PATCH 1/3] blktrace: delete garbage for message trace Jeff Moyer
2016-05-10 14:46 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49eg997w7o.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).