linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-block@vger.kernel.org, linux-nvdimm@ml01.01.org,
	axboe@kernel.dk
Subject: Re: [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events
Date: Wed, 16 Nov 2016 09:06:11 -0500	[thread overview]
Message-ID: <x49polvikoc.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20161116045657.GA30049@linux.intel.com> (Ross Zwisler's message of "Tue, 15 Nov 2016 21:56:57 -0700")

Ross Zwisler <ross.zwisler@linux.intel.com> writes:

> FWIW I think BRD has this same issue where we get block_bio_queue tracepoint
> events but not block_bio_complete.  Solving this in bio_endio() would fix that
> driver as well.

Yeah, there are several other drivers that will benefit.

> Where does the Q (bio enqueue), I (req insert), etc. naming show up?  Looking
> at a tracepoint trace in perf I don't see that naming.  Is that just a short
> hand used between developers, or is it something else?

That shorthand appears in blkparse and btt output (tools that are part
of blktrace).

Cheers,
Jeff

      reply	other threads:[~2016-11-16 14:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 19:08 [patch] nd_blk,nd_pmem,nd_btt: add endio blktrace events Jeff Moyer
2016-11-09 19:17 ` Christoph Hellwig
2016-11-09 19:31   ` Jeff Moyer
2016-11-09 19:34     ` Christoph Hellwig
2016-11-09 19:43       ` Jeff Moyer
2016-11-10 19:33         ` Christoph Hellwig
2016-11-11 14:55           ` Jeff Moyer
2016-11-16  4:56             ` Ross Zwisler
2016-11-16 14:06               ` Jeff Moyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x49polvikoc.fsf@segfault.boston.devel.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).