From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B5E5C433EF for ; Tue, 8 Mar 2022 22:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236504AbiCHWE2 (ORCPT ); Tue, 8 Mar 2022 17:04:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234181AbiCHWE1 (ORCPT ); Tue, 8 Mar 2022 17:04:27 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC5F57168; Tue, 8 Mar 2022 14:03:30 -0800 (PST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 228IXin0027268; Tue, 8 Mar 2022 22:03:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=tCRppCeFVbaxkOhWX+SNPUWRc7R5mYlr0BincOdEP8Q=; b=cDHFW4hXXnbl6TA689vL7Lj4LY2iB23pBIPGU/Jv35yq8P4Ifo3r4DLEl07hVpOFGKt+ HuPSMuC0si8WeX9rc1ObeY+Tsn95ghYLhKTsH63aosCvJolsgCqCF4H+vD+WLPmzd2us 3GvVd+5rOYeH8zvFAqWpsQHg2HM/w2qZz1glz5Kv+2dj4MX7i6lbOO0a5nEHXDjbMXmZ MoRFtAcKPcRaXNvkQHfvt3n/G1eumCdHd3Yo67s0q+7igPbYNiazGb1VtMefbDrY1hyV UoVaOZg/oa5ggBzleftXmGmnViWn4//EAp1hIiXAj5aSQxIM6I3mQtb6+7XZy5RbXa8W pQ== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 3env4ug749-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Mar 2022 22:03:17 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 228LmPd7017907; Tue, 8 Mar 2022 22:03:12 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03ams.nl.ibm.com with ESMTP id 3ekyg90fn7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Mar 2022 22:03:11 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 228M39CT31654146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Mar 2022 22:03:09 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B32BA405B; Tue, 8 Mar 2022 22:03:09 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 36619A4054; Tue, 8 Mar 2022 22:03:09 +0000 (GMT) Received: from localhost (unknown [9.171.69.133]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 8 Mar 2022 22:03:09 +0000 (GMT) Date: Tue, 8 Mar 2022 23:03:07 +0100 From: Vasily Gorbik To: Keith Busch Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com Subject: Re: [PATCHv4 6/8] crypto: add rocksoft 64b crc guard tag framework Message-ID: References: <20220303201312.3255347-1-kbusch@kernel.org> <20220303201312.3255347-7-kbusch@kernel.org> <20220308202747.GA3502158@dhcp-10-100-145-180.wdc.com> <20220308214612.GB3502158@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220308214612.GB3502158@dhcp-10-100-145-180.wdc.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: OIEJLqOoE_bT85ZWh-kNBAx5-nznZN4A X-Proofpoint-ORIG-GUID: OIEJLqOoE_bT85ZWh-kNBAx5-nznZN4A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-08_08,2022-03-04_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 mlxlogscore=862 malwarescore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203080111 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 08, 2022 at 01:46:12PM -0800, Keith Busch wrote: > On Tue, Mar 08, 2022 at 12:27:47PM -0800, Keith Busch wrote: > > On Tue, Mar 08, 2022 at 09:21:41PM +0100, Vasily Gorbik wrote: > > > On Thu, Mar 03, 2022 at 12:13:10PM -0800, Keith Busch wrote: > > > > Hardware specific features may be able to calculate a crc64, so provide > > > > a framework for drivers to register their implementation. If nothing is > > > > registered, fallback to the generic table lookup implementation. The > > > > implementation is modeled after the crct10dif equivalent. > > > > > > Hi Keith, > > > > > > this is failing on big-endian systems. I get the following on s390: > > > > Oh, I see the put_unaligned_le64() in chksum_final() was not the correct > > action. I'll send an update, thank you for the report. > > I'll set up a BE qemu target this week, but in the meantime, would you > be able to confirm if the following is successful? Sure, [ 0.543862] crc32: CRC_LE_BITS = 64, CRC_BE BITS = 64 [ 0.543864] crc32: self tests passed, processed 225944 bytes in 118678 nsec [ 0.543986] crc32c: CRC_LE_BITS = 64 [ 0.543987] crc32c: self tests passed, processed 112972 bytes in 58932 nsec [ 0.569479] crc32_combine: 8373 self tests passed [ 0.595330] crc32c_combine: 8373 self tests passed it does the trick. Thanks!