From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A72D8C433DF for ; Thu, 14 May 2020 22:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E1B52065D for ; Thu, 14 May 2020 22:20:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="XT/8LAMR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728383AbgENWUH (ORCPT ); Thu, 14 May 2020 18:20:07 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:39812 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728348AbgENWUG (ORCPT ); Thu, 14 May 2020 18:20:06 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04EMCW2e068482; Thu, 14 May 2020 22:19:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=dAWOxAMXOUS93j/PBYmGNlYGgOcQYNiAdTu4Myfy1oA=; b=XT/8LAMR3DZ5vcDVZkaxMZRvOobB0I29QLWx12HxrHHFKgSfxEgiYvzvqBem5+P0ZzHi /W7bdT3QOkEWs4NkByevnQKsT4r/hPPiz0UYTEJJqmv4mBO0HBFBzSc/Ae+cSgueMUsV sG79aVmfS9fFWcp+hIWosOFmJ/W6G36PA1n8tXpDr0K7TPJF7bU8GfUd+hOYElq4Zyv3 iWpCD4kZNJ9bvHhmb8tKGXz1eq0cYSoBllMTSjRZ7x1i7eKXKpYhIPNdITQ7sDGDkNWx 4Uc2cK2VxJrHwL+Y5qR6NVMHyxzbqPFYhbR3FyCj+vam3tSWCKX78TzJi+2V92kcLZK1 Dw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 3100yg5ers-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 May 2020 22:19:39 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04EM8hp8093183; Thu, 14 May 2020 22:19:38 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 3100yq659w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 May 2020 22:19:38 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 04EMJZoF019069; Thu, 14 May 2020 22:19:37 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 14 May 2020 15:19:35 -0700 To: Bart Van Assche Cc: Damien Le Moal , linux-nvme@lists.infradead.org, Christoph Hellwig , Keith Busch , Sagi Grimberg , linux-block@vger.kernel.org, Jens Axboe Subject: Re: [PATCH] nvme: Fix io_opt limit setting From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200514015452.1055278-1-damien.lemoal@wdc.com> Date: Thu, 14 May 2020 18:19:33 -0400 In-Reply-To: (Bart Van Assche's message of "Wed, 13 May 2020 21:47:16 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9621 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=590 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005140194 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9621 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 adultscore=0 cotscore=-2147483648 mlxscore=0 suspectscore=0 spamscore=0 impostorscore=0 mlxlogscore=619 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005140194 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Bart, > The above change looks confusing to me. We want the NVMe driver to set > io_opt, so why only call blk_queue_io_opt() if io_opt != 0? That means > that the io_opt value will be left to any value set by the block layer > core if io_opt == 0 instead of properly being set to zero. We do explicitly set it to 0 when allocating a queue. But no biggie. -- Martin K. Petersen Oracle Linux Engineering