From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EFA0C433FE for ; Tue, 8 Dec 2020 05:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3A9B23A61 for ; Tue, 8 Dec 2020 05:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbgLHF1x (ORCPT ); Tue, 8 Dec 2020 00:27:53 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:53278 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbgLHF1w (ORCPT ); Tue, 8 Dec 2020 00:27:52 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B85Ppkm125569; Tue, 8 Dec 2020 05:26:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=/jwYt2Z73c+ITeQo8z7ZtGAm5ZpbBfMQXPcXBP3v0zg=; b=v+k0w49nL0BA2m4REzJa0n3h5OUjs2VcVpj2WTVDt+gW9WjYmFUH0/BxCozIqZtfvHlf B0/msBA4U7gA2JiaKY+fW3dYkrjvX99bzNLGne8i16vRl/NhtxcSBIgYIlmwyJpXyIbL XFyIiJrDFxY6t9i4tRVFXmmWGtq9iJ4C/c+YP5/QzTgXRJS4XpclaEccZ9GtWfB4FEdp sJ5W5zfJMHI6muCDmlvHc16qqE3M/TqiWo4B5gKJy8OGiAnZvCA+zd/2dZD2jLF32gKJ MJR3sMtWWIfC1xwF5M4E934Gclx/QZl1JANzLFaFYcvtaE2xfGvvyM3POZnsQAVjyeme VA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 35825m0v2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 08 Dec 2020 05:26:56 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B855gd4189287; Tue, 8 Dec 2020 05:24:55 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 358m4x8as9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 Dec 2020 05:24:55 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0B85OqYw011549; Tue, 8 Dec 2020 05:24:53 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 Dec 2020 21:24:52 -0800 To: Christoph Hellwig Cc: Jens Axboe , "Martin K . Petersen" , Oleksii Kurochko , Sagi Grimberg , Mike Snitzer , Ilya Dryomov , Dongsheng Yang , ceph-devel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Hannes Reinecke Subject: Re: [PATCH 3/6] block: add a hard-readonly flag to struct gendisk From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-4-hch@lst.de> Date: Tue, 08 Dec 2020 00:24:49 -0500 In-Reply-To: <20201207131918.2252553-4-hch@lst.de> (Christoph Hellwig's message of "Mon, 7 Dec 2020 14:19:15 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=1 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=939 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080031 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=950 clxscore=1015 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080032 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Christoph, > Commit 20bd1d026aac ("scsi: sd: Keep disk read-only when re-reading > partition") addressed a long-standing problem with user read-only > policy being overridden as a result of a device-initiated revalidate. > The commit has since been reverted due to a regression that left some > USB devices read-only indefinitely. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering