From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@meta.com>
Cc: <hch@lst.de>, <linux-nvme@lists.infradead.org>,
<linux-block@vger.kernel.org>, <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv5 1/2] block: accumulate memory segment gaps per bio
Date: Tue, 14 Oct 2025 17:18:15 -0400 [thread overview]
Message-ID: <yq18qhdchdv.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251014150456.2219261-2-kbusch@meta.com> (Keith Busch's message of "Tue, 14 Oct 2025 08:04:55 -0700")
Keith,
> The blk-mq dma iterator has an optimization for requests that align to
> the device's iommu merge boundary. This boundary may be larger than
> the device's virtual boundary, but the code had been depending on that
> queue limit to know ahead of time if the request is guaranteed to
> align to that optimization.
>
> Rather than rely on that queue limit, which many devices may not
> report, save the lowest set bit of any boundary gap between each
> segment in the bio while checking the segments. The request stores the
> value for merging and quickly checking per io if the request can use
> iova optimizations.
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
next prev parent reply other threads:[~2025-10-14 21:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 15:04 [PATCHv5 0/2] block, nvme: removing virtual boundary mask reliance Keith Busch
2025-10-14 15:04 ` [PATCHv5 1/2] block: accumulate memory segment gaps per bio Keith Busch
2025-10-14 21:18 ` Martin K. Petersen [this message]
2025-10-15 4:08 ` Christoph Hellwig
2025-11-11 4:26 ` Matthew Wilcox
2025-11-11 4:50 ` Keith Busch
2025-11-11 7:14 ` Christoph Hellwig
2025-11-11 9:36 ` Yu Kuai
2025-11-11 9:39 ` Christoph Hellwig
2025-11-11 10:14 ` Yu Kuai
2025-11-11 13:25 ` Keith Busch
2025-11-11 13:40 ` Christoph Hellwig
2025-11-11 13:54 ` Keith Busch
2025-11-11 13:58 ` Christoph Hellwig
2025-11-11 14:03 ` Yu Kuai
2025-10-14 15:04 ` [PATCHv5 2/2] nvme: remove virtual boundary for sgl capable devices Keith Busch
2025-10-14 21:19 ` Martin K. Petersen
2025-11-07 1:03 ` [PATCHv5 0/2] block, nvme: removing virtual boundary mask reliance Keith Busch
2025-11-07 1:12 ` Jens Axboe
2025-11-07 1:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18qhdchdv.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox