From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
Keith Busch <kbusch@kernel.org>,
Davidlohr Bueso <dave@stgolabs.net>, Fan Ni <fan.ni@samsung.com>,
Pankaj Raghav <p.raghav@samsung.com>,
Daniel Gomez <da.gomez@samsung.com>,
Boaz Harrosh <boazh@netapp.com>,
Adam Manzanares <a.manzanares@samsung.com>
Subject: Re: [PATCH 3/5] brd: make sector size configurable
Date: Mon, 20 Mar 2023 19:40:44 -0400 [thread overview]
Message-ID: <yq18rfrt3gp.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <ZBjjlLTxWIp9rY7J@bombadil.infradead.org> (Luis Chamberlain's message of "Mon, 20 Mar 2023 15:52:04 -0700")
Luis,
> /sys/block/<disk>/queue/minimum_io_size
>
> The documentation suggests " For disk drives this is often the
> physical block size."
>
> /sys/block/<disk>/queue/optimal_io_size
>
> The documentation suggests this is "This is rarely reported for disk
> drives."
min_io and opt_io are used to key mkfs.xfs' sunit/swidth. So if you're
using a hardware RAID, MD, or DM, we'll attempt to align allocations on
stripe boundaries.
Back when that "rarely reported" blurb was written (2009), we did not
have any individual disk drives which reported min_io/opt_io. Reporting
those parameters was mostly a storage array thing. These days it's
fairly common for both disk drives and SSDs to fill out these fields.
> From my review of xfs's mkfs is we essentially use the physical block
> size as a default sector size if set, otherwise we use the device's
> logical block size if set otherwise xfsprog's default and so 4096.
Yep.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-03-20 23:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230307114200eucas1p296a60514feb40c4a08f380cc28aeeb51@eucas1p2.samsung.com>
2023-03-06 12:01 ` [PATCH 0/5] brd: Allow to change block sizes Hannes Reinecke
2023-03-06 12:01 ` [PATCH 1/5] brd: convert to folios Hannes Reinecke
2023-03-06 16:04 ` kernel test robot
2023-03-06 17:37 ` Matthew Wilcox
2023-03-07 6:55 ` Hannes Reinecke
2023-03-07 7:30 ` Matthew Wilcox
2023-03-09 3:28 ` Luis Chamberlain
[not found] ` <a4489f7b-912c-e68f-4a4c-c14d96026bd6@suse.de>
2023-03-21 15:00 ` Matthew Wilcox
2023-03-21 15:26 ` Hannes Reinecke
2023-03-09 2:29 ` Luis Chamberlain
2023-03-06 12:01 ` [PATCH 2/5] brd: abstract page_size conventions Hannes Reinecke
2023-03-06 12:01 ` [PATCH 3/5] brd: make sector size configurable Hannes Reinecke
2023-03-09 3:12 ` Luis Chamberlain
2023-03-20 22:52 ` Luis Chamberlain
2023-03-20 23:40 ` Martin K. Petersen [this message]
2023-03-21 0:14 ` Luis Chamberlain
2023-03-06 12:01 ` [PATCH 4/5] brd: limit maximal block size to 32M Hannes Reinecke
2023-03-06 17:40 ` Matthew Wilcox
2023-03-07 6:56 ` Hannes Reinecke
2023-03-06 18:01 ` Keith Busch
2023-03-07 6:57 ` Hannes Reinecke
2023-03-06 12:01 ` [PATCH 5/5] brd: make logical sector size configurable Hannes Reinecke
2023-03-07 9:01 ` Pankaj Raghav
2023-03-07 11:06 ` Hannes Reinecke
2023-05-17 9:31 ` Pankaj Raghav
2023-03-07 11:33 ` [PATCH 0/5] brd: Allow to change block sizes Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18rfrt3gp.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=a.manzanares@samsung.com \
--cc=axboe@kernel.dk \
--cc=boazh@netapp.com \
--cc=da.gomez@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).