From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, colyli@suse.de,
linux-bcache@vger.kernel.org, linux-btrace@vger.kernel.org,
xen-devel@lists.xenproject.org, kent.overstreet@gmail.com,
yuchao0@huawei.com, jaegeuk@kernel.org, damien.lemoal@wdc.com,
konrad.wilk@oracle.com, roger.pau@citrix.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH V4 1/9] block: add a helper function to read nr_setcs
Date: Thu, 11 Jul 2019 21:59:24 -0400 [thread overview]
Message-ID: <yq18st457yb.fsf@oracle.com> (raw)
In-Reply-To: <20190708184711.2984-2-chaitanya.kulkarni@wdc.com> (Chaitanya Kulkarni's message of "Mon, 8 Jul 2019 11:47:03 -0700")
Hi Chaitanya,
> +static inline sector_t bdev_nr_sects(struct block_device *bdev)
> +{
> + return part_nr_sects_read(bdev->bd_part);
> +}
Can bdev end up being NULL in any of the call sites?
Otherwise no objections.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-07-12 1:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 18:47 [PATCH V4 0/9] block: use right accessor to read nr_sects Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 1/9] block: add a helper function to read nr_setcs Chaitanya Kulkarni
2019-07-12 1:59 ` Martin K. Petersen [this message]
2019-07-12 16:09 ` Chaitanya Kulkarni
2019-07-17 2:28 ` Martin K. Petersen
2019-07-08 18:47 ` [PATCH V4 2/9] blk-zoned: update blkdev_nr_zones() with helper Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 3/9] blk-zoned: update blkdev_report_zone() " Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 4/9] blk-zoned: update blkdev_reset_zones() " Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 5/9] bcache: update cached_dev_init() " Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 6/9] f2fs: use helper in init_blkz_info() Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 7/9] blktrace: use helper in blk_trace_setup_lba() Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 8/9] target/pscsi: use helper in pscsi_get_blocks() Chaitanya Kulkarni
2019-07-08 18:47 ` [PATCH V4 9/9] xen/blkback: use helper in vbd_sz() Chaitanya Kulkarni
2019-07-15 10:36 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18st457yb.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=colyli@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=jaegeuk@kernel.org \
--cc=kent.overstreet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).