From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: use req_op() to maintain consistency
Date: Thu, 13 Jun 2019 12:54:54 -0400 [thread overview]
Message-ID: <yq18su5togx.fsf@oracle.com> (raw)
In-Reply-To: <20190613141421.2698-1-chaitanya.kulkarni@wdc.com> (Chaitanya Kulkarni's message of "Thu, 13 Jun 2019 07:14:21 -0700")
Chaitanya,
> This is a pure code cleanup patch and doesn't change any functionality.
> In block layer to identify the request operation req_op() macro is
> used, so change the open coding the req_op() in the blk-mq-debugfs.c.
Looks good.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-06-13 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 14:14 [PATCH] block: use req_op() to maintain consistency Chaitanya Kulkarni
2019-06-13 16:54 ` Martin K. Petersen [this message]
2019-06-17 8:41 ` Hannes Reinecke
2019-06-17 15:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18su5togx.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).