linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	Kanchan Joshi <joshi.k@samsung.com>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-nvme@lists.infradead.org
Subject: Re: fine-grained PI control
Date: Mon, 23 Sep 2024 21:59:10 -0400	[thread overview]
Message-ID: <yq1bk0dhlko.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240918063910.hqntgm5jy2jisys2@green245> (Anuj Gupta's message of "Wed, 18 Sep 2024 12:09:10 +0530")


Hi Anuj!

> When the drive is formatted with type1 integrity and dix is supported,
> the block layer would generate/verify the guard and reftag. For scsi,
> apptag would also need to be generated/verified as reftag-check can't
> be specified alone. But I am not not able to find (in SCSI code) where
> exactly: 1. this apptag is being generated
> 2. and getting added to the PI buffer and scsi command.

The block layer on its own doesn't have a way to fill out the app tag in
any meaningful way. But if the PI comes from userland, the application
can set the app tag to whatever it pleases.

Originally we had code in Linux allowing filesystems to attach
additional metadata to bios which would then be stored in the app tag
space. This was intended for backpointers but never really took off.
However, if we move the burden of PI generation to filesystems as
Christoph suggested, then we can revisit using the app tag space.

No matter what, though, for target we need to be able to store whichever
app tag the initiator sends.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2024-09-24  1:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05  8:32 fine-grained PI control Christoph Hellwig
2024-07-08 14:17 ` Anuj gupta
2024-07-09  7:08   ` Christoph Hellwig
2024-07-09  3:35 ` Martin K. Petersen
2024-07-09  7:16   ` Christoph Hellwig
2024-07-10  3:47     ` Martin K. Petersen
2024-07-11  5:42       ` Christoph Hellwig
2024-07-16  2:07         ` Martin K. Petersen
2024-07-26 10:21     ` Anuj Gupta
2024-07-29 17:03       ` Christoph Hellwig
     [not found]   ` <CGME20240918064651epcas5p418d61389752da25e5fc50e6a50a111b8@epcas5p4.samsung.com>
2024-09-18  6:39     ` Anuj Gupta
2024-09-24  1:59       ` Martin K. Petersen [this message]
2024-09-24  5:36         ` Christoph Hellwig
2024-09-27  2:01           ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1bk0dhlko.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=anuj20.g@samsung.com \
    --cc=hch@lst.de \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).