From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de,
martin.petersen@oracle.com, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
gost.dev@samsung.com
Subject: Re: [PATCH 0/3] Block integrity with flexibile-offset PI
Date: Wed, 31 Jan 2024 12:48:40 -0500 [thread overview]
Message-ID: <yq1bk91s8bn.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240130171206.4845-1-joshi.k@samsung.com> (Kanchan Joshi's message of "Tue, 30 Jan 2024 22:42:03 +0530")
Kanchan,
> The block integrity subsystem can only work with PI placed in the
> first bytes of the metadata buffer.
>
> The series makes block-integrity support the flexible placement of PI.
> And changes NVMe driver to make use of the new capability.
>
> This helps to
> (i) enable the more common case for NVMe (PI in last bytes is the norm)
> (ii) reduce nop profile users (tried by Jens recently [1]).
Looks OK to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2024-01-31 17:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240130171918epcas5p3cd0e3e9c7fb9a74c8464b06779c378ea@epcas5p3.samsung.com>
2024-01-30 17:12 ` [PATCH 0/3] Block integrity with flexibile-offset PI Kanchan Joshi
2024-01-30 17:12 ` [PATCH 1/3] block: refactor guard helpers Kanchan Joshi
2024-01-31 7:16 ` Christoph Hellwig
2024-01-31 12:43 ` Sagi Grimberg
2024-01-30 17:12 ` [PATCH 2/3] block: support PI at non-zero offset within metadata Kanchan Joshi
2024-01-31 7:21 ` Christoph Hellwig
2024-01-31 12:43 ` Sagi Grimberg
2024-01-30 17:12 ` [PATCH 3/3] nvme: allow integrity when PI is not in first bytes Kanchan Joshi
2024-01-31 7:22 ` Christoph Hellwig
2024-01-31 12:43 ` Sagi Grimberg
2024-01-31 17:44 ` [PATCH 0/3] Block integrity with flexibile-offset PI Keith Busch
2024-01-31 17:48 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bk91s8bn.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).