From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-block@vger.kernel.org, hch@lst.de, hare@suse.com
Subject: Re: [PATCH V2 2/2] block: add more debug data to print_req_err
Date: Thu, 13 Jun 2019 12:53:57 -0400 [thread overview]
Message-ID: <yq1d0jhtoii.fsf@oracle.com> (raw)
In-Reply-To: <d369fbbd-0d98-b804-619b-23049ee12398@acm.org> (Bart Van Assche's message of "Thu, 13 Jun 2019 08:17:34 -0700")
Bart,
> If this patch gets applied there will be three copies in the upstream
> code that convert a REQ_OP_* constant into a string: one in
> blk-core.c, one in blk-mq-debugfs.c and one in
> include/trace/events/f2fs.h. Is it possible to avoid that duplication
> and have only one function that does the number-to-string conversion?
People often have a hard time correlating SCSI and block error messages
with tracing output. So in general I'd like to see us not just trying to
standardize the helper functions, but the actual output.
I.e. I think it would be great to print exactly the same string for both
error log messages and tracepoints. Since Chaitanya is doing a lot of
work in this area anyway, that may be worth looking into?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-06-13 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 14:16 [PATCH V2 0/2] block: improve print_req_error Chaitanya Kulkarni
2019-06-13 14:16 ` [PATCH 1/2] " Chaitanya Kulkarni
2019-06-13 14:16 ` [PATCH V2 2/2] block: add more debug data to print_req_err Chaitanya Kulkarni
2019-06-13 15:17 ` Bart Van Assche
2019-06-13 16:09 ` Chaitanya Kulkarni
2019-06-13 16:53 ` Martin K. Petersen [this message]
2019-06-13 17:05 ` Bart Van Assche
2019-06-13 17:43 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0jhtoii.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).