From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Bart Van Assche Cc: "osandov\@osandov.com" , "martin.petersen\@oracle.com" , "linux-scsi\@vger.kernel.org" , "James.Bottomley\@HansenPartnership.com" , "linux-block\@vger.kernel.org" , "osandov\@fb.com" , "hare\@suse.com" , "axboe\@kernel.dk" Subject: Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() From: "Martin K. Petersen" References: <20170421234026.18970-1-bart.vanassche@sandisk.com> <20170421234026.18970-11-bart.vanassche@sandisk.com> <1493070575.3394.19.camel@sandisk.com> <20170424232359.GA21578@vader.DHCP.thefacebook.com> <1493077595.3394.32.camel@sandisk.com> Date: Tue, 25 Apr 2017 12:40:10 -0400 In-Reply-To: <1493077595.3394.32.camel@sandisk.com> (Bart Van Assche's message of "Mon, 24 Apr 2017 23:46:36 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: Bart, >> I was merely objecting to the fact that we already have umpteen existing >> interfaces for displaying SCSI command information. > Do you perhaps want me to change the for-loop into a call to > __scsi_format_command()? If possible, I would love to see some commonality in the per-command information regardless of whether it is displayed due to SCSI logging, SCSI tracing or an error condition. -- Martin K. Petersen Oracle Linux Engineering