From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1050.oracle.com ([141.146.126.70]:50982 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbdBXBdf (ORCPT ); Thu, 23 Feb 2017 20:33:35 -0500 To: Ilya Dryomov Cc: "Martin K. Petersen" , Ceph Development , linux-block@vger.kernel.org, Dan Williams , Christoph Hellwig Subject: Re: blk_integrity_revalidate() clears BDI_CAP_STABLE_WRITES From: "Martin K. Petersen" References: Date: Thu, 23 Feb 2017 18:49:01 -0500 In-Reply-To: (Ilya Dryomov's message of "Wed, 22 Feb 2017 15:41:43 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org >>>>> "Ilya" == Ilya Dryomov writes: Ilya, Ilya> Well, blk_integrity_revalidate() doesn't clear the profile, it Ilya> just clears the stable pages flag. Whoever calls Ilya> blk_integrity_unregister() to clear the profile can also clear the Ilya> stable pages flag -- why not let blk_integrity_unregister() clear Ilya> the flag like I suggested? That's what it used to do. blk_integrity_revalidate() was obviously introduced to overcome some problem. Unfortunately, I can't recall what that was and Google isn't being particularly helpful. I suspect it was either in the NVDIMM or NVMe camps since that's where the churn was. I don't have a problem with your patch as long as we're sure there are no regressions. I would carry the gendisk check over, though. -- Martin K. Petersen Oracle Linux Engineering