linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, kernel test robot <lkp@intel.com>,
	Keith Busch <kbusch@meta.com>,
	linux-block@vger.kernel.org, axboe@kernel.dk,
	llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	martin.petersen@oracle.com
Subject: Re: [PATCH] block: save user max_sectors limit
Date: Thu, 22 Dec 2022 11:07:24 -0500	[thread overview]
Message-ID: <yq1ili3bf5n.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <Y6R6geqKfvV5/jBU@kbusch-mbp.dhcp.thefacebook.com> (Keith Busch's message of "Thu, 22 Dec 2022 08:40:49 -0700")


Keith,

> But thinking on this again, we probably want to respect the user
> setting even if it's lower than the default too, not just if its
> larger. I believe that will require a new queue limit to save that
> value.

Yeah, I have struggled with the same problem for various user parameter
overrides in SCSI. Lowering defaults or detected values is fairly
common.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2022-12-22 16:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 16:27 [PATCH] block: save user max_sectors limit Keith Busch
     [not found] ` <202212221657.yQawgPsu-lkp@intel.com>
2022-12-22  8:40   ` Christoph Hellwig
2022-12-22 15:40     ` Keith Busch
2022-12-22 16:07       ` Martin K. Petersen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-12-22 17:52 Keith Busch
2022-12-23  6:00 ` Christoph Hellwig
2022-12-27 16:49   ` Keith Busch
2022-12-27 16:53     ` Christoph Hellwig
2022-12-27  2:13 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ili3bf5n.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-block@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).