From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Daan De Meyer <daan.j.demeyer@gmail.com>
Cc: phil@philpotter.co.uk, martin.petersen@oracle.com,
James.Bottomley@HansenPartnership.com, axboe@kernel.dk,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Daan De Meyer <daan@amutable.com>
Subject: Re: [PATCH v2] cdrom, scsi: sr: propagate read-only status to block layer via set_disk_ro()
Date: Sun, 26 Apr 2026 21:29:35 -0400 [thread overview]
Message-ID: <yq1jytti447.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260422113206.246267-1-daan@amutable.com> (Daan De Meyer's message of "Wed, 22 Apr 2026 11:32:06 +0000")
Daan,
> Fix this by factoring the GET CONFIGURATION probing out of
> cdrom_open_write() into a new exported helper,
> cdrom_probe_write_features(), and having sr call it from sr_probe()
> right after get_capabilities() has populated the MODE SENSE bits.
> register_cdrom() then calls set_disk_ro() based on the full
> write-capability mask (CDC_DVD_RAM | CDC_MRW_W | CDC_RAM | CDC_CD_RW)
> so the block layer reflects the drive's actual write support.
LGTM.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen
prev parent reply other threads:[~2026-04-27 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260330133403.796330-1-daan@amutable.com>
2026-04-22 11:32 ` [PATCH v2] cdrom, scsi: sr: propagate read-only status to block layer via set_disk_ro() Daan De Meyer
2026-04-23 21:06 ` Phillip Potter
2026-04-26 21:03 ` Phillip Potter
2026-04-26 21:06 ` Daan De Meyer
2026-04-27 1:29 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1jytti447.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=daan.j.demeyer@gmail.com \
--cc=daan@amutable.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox