From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com,
joshi.k@samsung.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: reuse original bio_vec array for integrity during clone
Date: Tue, 02 Jul 2024 22:13:51 -0400 [thread overview]
Message-ID: <yq1jzi3cjko.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240702100753.2168-1-anuj20.g@samsung.com> (Anuj Gupta's message of "Tue, 2 Jul 2024 15:37:53 +0530")
Anuj,
> Modify bio_integrity_clone to reuse the original bvec array instead of
> allocating and copying it, similar to how bio data path is cloned.
Pointing to the original bvec array when cloning was the original
approach. I'm not sure how we ended up copying, presumably that was done
as part of the iter conversion efforts. In any case this change is fine
with me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-07-03 2:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240702101517epcas5p3f651d9307bab6ece4d3e450ed61deb82@epcas5p3.samsung.com>
2024-07-02 10:07 ` [PATCH] block: reuse original bio_vec array for integrity during clone Anuj Gupta
2024-07-02 12:00 ` Christoph Hellwig
2024-07-03 2:13 ` Martin K. Petersen [this message]
2024-07-03 3:08 ` Ming Lei
2024-07-03 4:46 ` Christoph Hellwig
2024-07-03 5:16 ` Ming Lei
2024-07-04 8:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1jzi3cjko.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox