Re: [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions

Ming Lei
2020-12-09T01:25:08Z

On Tue, Dec 08, 2020 at 11:59:27AM +0100, Christoph Hellwig wrote:
> On Tue, Dec 08, 2020 at 06:29:23PM +0800, Ming Lei wrote:
> > > - test_bit(GD_READ_ONLY, &bdev->bd_disk->state);
> > > + return bdev->bd_read_only || get_disk_ro(bdev->bd_disk);
> > > }
> > > EXPORT_SYMBOL(bdev_read_only);
> >
> > I think this patch should be folded into previous one, otherwise
> > bdev_read_only(part) may return false even though ioctl(BLKROSET)
> > has been done on the whole disk.
>
> The above is the existing behavior going back back very far, and I feel
> much more comfortable having a small self-contained patch that changes
> this behavior.
>

OK, then looks fine:

Reviewed-by: Ming Lei <ming.lei@redhat.com>

--
Ming