Re: [PATCH] scsi: ufs: mark HPB support as BROKEN

Bart Van Assche
2021-10-26T16:36:48Z

On 10/26/21 12:12 AM, Christoph Hellwig wrote:
> The HPB support added this merge window is fundanetally flawed as it
^^^^^^^^^^^^
fundanetally -> fundamentally

Since the implementation can be reworked not to use
blk_insert_cloned_request() I'm not sure using the word "fundamentally"
is appropriate.

> uses blk_insert_cloned_request to insert a cloned request onto the same
> queue as the one that the original request came from, leading to all
> kinds of issues in blk-mq accounting (in addition to this API being
> a special case for dm-mpath that should not see other users).

More detailed information would have been welcome.

> Fixes: f02bc9754a68 ("scsi: ufs: ufshpb: Introduce Host Performance Buffer
> feature")

I assume that you wanted to refer to commit 41d8a9333cc9 ("scsi: ufs: ufshpb:
Add HPB 2.0 support") instead since that commit is the only commit that
introduced a blk_insert_cloned_request() call in the UFS HPB code?

Bart.