Re: [PATCH] scsi: ufs: mark HPB support as BROKEN

James Bottomley
2021-10-26T13:04:20Z

On Tue, 2021-10-26 at 16:24 +0900, Damien Le Moal wrote:
> On 2021/10/26 16:12, Christoph Hellwig wrote:
> > The HPB support added this merge window is fundanetally

And s/n/m/ while you're at it: fundamentally

Otherwise:

Reviewed-by: James E.J. Bottomley <jejb@linux.ibm.com>

James

> > flawed as it uses blk_insert_cloned_request to insert a cloned
> > request onto the same queue as the one that the original request
> > came from, leading to all kinds of issues in blk-mq accounting (in
> > addition to this API being a special case for dm-mpath that should
> > not see other users).
> >
> > Mark is as BROKEN as the non-intrusive alternative to a last minute
>
> s/Mark is/Mark it
>
> > large scale revert.
> >
> > Fixes: f02bc9754a68 ("scsi: ufs: ufshpb: Introduce Host Performance
> > Buffer
> > feature")
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > drivers/scsi/ufs/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> > index 432df76e6318a..7835d9082aae4 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -186,7 +186,7 @@ config SCSI_UFS_CRYPTO
> >
> > config SCSI_UFS_HPB
> > bool "Support UFS Host Performance Booster"
> > - depends on SCSI_UFSHCD
> > + depends on SCSI_UFSHCD && BROKEN
> > help
> > The UFS HPB feature improves random read performance. It
> > caches
> > L2P (logical to physical) map of UFS to host DRAM. The driver
> > uses HPB
> >
>
> Otherwise, looks good to me.
>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
>