public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: make bio auto-integrity deadlock safe
Date: Sun, 02 Nov 2025 22:24:56 -0500	[thread overview]
Message-ID: <yq1seevreai.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251030144530.1372226-3-hch@lst.de> (Christoph Hellwig's message of "Thu, 30 Oct 2025 15:44:54 +0100")


Christoph,

> + * Maximum size of I/O that needs a block layer integrity buffer.  Limited
> + * by the number of intervals for whuich we can fit the integrity buffer into

which

> + * the buffer size.  Because the the buffer is a single segment it is also
> + * limited by the maximum segments size.

segment

> + */
> +static inline unsigned int max_integrity_io_size(struct queue_limits *lim)
> +{
> +	return min_t(unsigned int, lim->max_segment_size,
> +		(BLK_INTEGRITY_MAX_SIZE / lim->integrity.metadata_size) <<
> +			lim->integrity.interval_exp);
> +}

Otherwise OK.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen

  reply	other threads:[~2025-11-03  3:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30 14:44 make block layer auto-PI deadlock safe v2 Christoph Hellwig
2025-10-30 14:44 ` [PATCH 1/2] block: blocking mempool_alloc doesn't fail Christoph Hellwig
2025-10-30 14:44 ` [PATCH 2/2] block: make bio auto-integrity deadlock safe Christoph Hellwig
2025-11-03  3:24   ` Martin K. Petersen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-11-03 10:16 make block layer auto-PI deadlock safe v3 Christoph Hellwig
2025-11-03 10:16 ` [PATCH 2/2] block: make bio auto-integrity deadlock safe Christoph Hellwig
2025-11-03 11:15   ` Kanchan Joshi
2025-11-03 13:20   ` Anuj gupta
2025-11-03 13:40   ` Johannes Thumshirn
2025-11-03 13:45     ` hch
2025-11-03 13:47       ` Johannes Thumshirn
2025-11-03 13:49         ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1seevreai.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox