From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A0B9C4361B for ; Tue, 8 Dec 2020 05:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5C2B23A61 for ; Tue, 8 Dec 2020 05:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbgLHF36 (ORCPT ); Tue, 8 Dec 2020 00:29:58 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:47862 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbgLHF36 (ORCPT ); Tue, 8 Dec 2020 00:29:58 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B85PsUK160259; Tue, 8 Dec 2020 05:29:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=8RZFhY374YxRU7wZzkbyymuA3HBrUUjHnKaMHjvD0Pg=; b=Y+cziqEsSOOWByyffK5q+fwU9tYZaFoN7JPjqblyzgBntMN9fqD46Xc1l5sjAfuBvdPt Jv6BurV0LqaKRey7KPGe80iXoSTaVWnVkSVWZdHQ73QymkVxwyy26B8qc0Hfix3WsJs7 hL0v5nfswhjpu+ELmuLQ5O9XaS0KzydTWQ5sVHpYjiiPb1ThGPjXGt74XLA55xv81sfJ gZ2+PRiEKfGxf6S4ARZuuIjEvwmCpicU+kGCvPxxHiL3ibfc1miMrmdFUbJtBUgalRT+ 5JHWyi7Xuv8mjxC+uaJUnFIrxfbxkFYvVYcKibG8M5A7gmfV0kXXkzWKTpFYkgTmX4FU hA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 357yqbryty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 08 Dec 2020 05:29:01 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B85Qb1V058091; Tue, 8 Dec 2020 05:29:01 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 358m3x8fen-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 Dec 2020 05:29:01 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B85T0Je020284; Tue, 8 Dec 2020 05:29:00 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 Dec 2020 21:29:00 -0800 To: Christoph Hellwig Cc: Jens Axboe , "Martin K . Petersen" , Oleksii Kurochko , Sagi Grimberg , Mike Snitzer , Ilya Dryomov , Dongsheng Yang , ceph-devel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, Hannes Reinecke Subject: Re: [PATCH 3/6] block: add a hard-readonly flag to struct gendisk From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-4-hch@lst.de> Date: Tue, 08 Dec 2020 00:28:57 -0500 In-Reply-To: <20201207131918.2252553-4-hch@lst.de> (Christoph Hellwig's message of "Mon, 7 Dec 2020 14:19:15 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=1 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080032 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 mlxlogscore=999 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080032 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Christoph, > diff --git a/block/blk-core.c b/block/blk-core.c > index ad041e903b0a8f..ecd68415c6acad 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -693,7 +693,7 @@ static inline bool should_fail_request(struct block_device *part, > > static inline bool bio_check_ro(struct bio *bio) > { > - if (op_is_write(bio_op(bio)) && bio->bi_bdev->bd_read_only) { > + if (op_is_write(bio_op(bio)) && bdev_read_only(bio->bi_bdev)) Build failure, opening brace is missing ^^^^^ > char b[BDEVNAME_SIZE]; > > if (op_is_flush(bio->bi_opf) && !bio_sectors(bio)) -- Martin K. Petersen Oracle Linux Engineering