From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D86C76192 for ; Wed, 17 Jul 2019 02:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37D3920818 for ; Wed, 17 Jul 2019 02:28:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="t6OqAWSH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725912AbfGQC25 (ORCPT ); Tue, 16 Jul 2019 22:28:57 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:34824 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfGQC25 (ORCPT ); Tue, 16 Jul 2019 22:28:57 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6H2O2b4074080; Wed, 17 Jul 2019 02:28:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=x0TkQOL90rKxjjC6Of7Ba76QmcmKOQRx6t2pSFqNMjI=; b=t6OqAWSHi7kmp+rGZNtsNE7jL3XrH89bgCBfz+fz24gaswR/MG5Dghzhm74zg4TTMF0n Y+24tSUaWebG3clzOXCOOngRVOjy0zeyDc67URn2dX9Ho/usZThsJZFRl7UMPuJ5QxND rpXBBrsoJKVBQJdOBR16KzFQyq5JpHLGb+q8fjUTSYHgQ3J8djt9+OmpcOyV38lO0X7a u/vNvLC5BI+HzPpfEaB4jqrm2uGjK3cGbKgXRo29A9tqVSfGyC1RdQAZ/ncVbfbXM+sz 2pEIzp6jH65OiGkVisBgfS8u3hS3lzONsCqLEWPFIHFZbzrxxgGtxc/8cEmSeIXivVeB Mw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2tq6qtqux7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jul 2019 02:28:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6H2RYQ3106662; Wed, 17 Jul 2019 02:28:36 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2tq5bcr1sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jul 2019 02:28:36 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6H2SYgN021673; Wed, 17 Jul 2019 02:28:34 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 17 Jul 2019 02:28:33 +0000 To: Chaitanya Kulkarni Cc: "Martin K. Petersen" , "linux-block\@vger.kernel.org" , "colyli\@suse.de" , "linux-bcache\@vger.kernel.org" , "linux-btrace\@vger.kernel.org" , "xen-devel\@lists.xenproject.org" , "kent.overstreet\@gmail.com" , "yuchao0\@huawei.com" , "jaegeuk\@kernel.org" , Damien Le Moal , "konrad.wilk\@oracle.com" , "roger.pau\@citrix.com" , "bvanassche\@acm.org" , "linux-scsi\@vger.kernel.org" Subject: Re: [PATCH V4 1/9] block: add a helper function to read nr_setcs From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190708184711.2984-1-chaitanya.kulkarni@wdc.com> <20190708184711.2984-2-chaitanya.kulkarni@wdc.com> Date: Tue, 16 Jul 2019 22:28:30 -0400 In-Reply-To: (Chaitanya Kulkarni's message of "Fri, 12 Jul 2019 16:09:56 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9320 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=930 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907170029 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9320 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=983 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907170028 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Chaitanya, > This series just replaces the existing accesses without changing > anything. > > So if any of the exiting code has that bug then it will blow up > nicely. > > For future callers I don't mind adding a new check and resend the > series. > > Would you prefer adding a check ? I checked your call sites and they look fine. Also, I don't think returning a capacity of 0 on error is going to help us much. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering