From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-block@vger.kernel.org, hch@lst.de, hare@suse.com
Subject: Re: [PATCH V2 2/2] block: add more debug data to print_req_err
Date: Thu, 13 Jun 2019 13:43:00 -0400 [thread overview]
Message-ID: <yq1tvcts7ob.fsf@oracle.com> (raw)
In-Reply-To: <be1e3944-4f5a-ca40-1496-614058fd3bb2@acm.org> (Bart Van Assche's message of "Thu, 13 Jun 2019 10:05:12 -0700")
Bart,
> I'm in favor of improving consistency. But are you sure that we can
> modify the tracing output format without breaking any applications?
Chaitanya is already working on enhancing tracing. I seem to recall
blktrace being fairly flexible with what it digests.
On top of that, we also have the option of changing the error path
output as opposed to changing the tracing ditto should that be an issue.
My main point is that there is probably going to be close to a 1:1
mapping between what you would want to see in an error message and what
you would want to see in tracing. So it would be good to use the same
plumbing for both.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-06-13 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 14:16 [PATCH V2 0/2] block: improve print_req_error Chaitanya Kulkarni
2019-06-13 14:16 ` [PATCH 1/2] " Chaitanya Kulkarni
2019-06-13 14:16 ` [PATCH V2 2/2] block: add more debug data to print_req_err Chaitanya Kulkarni
2019-06-13 15:17 ` Bart Van Assche
2019-06-13 16:09 ` Chaitanya Kulkarni
2019-06-13 16:53 ` Martin K. Petersen
2019-06-13 17:05 ` Bart Van Assche
2019-06-13 17:43 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tvcts7ob.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).