From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
"linux-block\@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme\@lists.infradead.org"
<linux-nvme@lists.infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: Regression: NVMe: kernel BUG at lib/sg_pool.c:103!
Date: Wed, 20 Feb 2019 17:55:04 -0500 [thread overview]
Message-ID: <yq1tvgyhxyv.fsf@oracle.com> (raw)
In-Reply-To: <SN6PR04MB45276D80E3181896ABF39D1E867D0@SN6PR04MB4527.namprd04.prod.outlook.com> (Chaitanya Kulkarni's message of "Wed, 20 Feb 2019 18:16:27 +0000")
Chaitanya,
> - if (!blk_rq_payload_bytes(rq))
> + if (!blk_rq_nr_phys_segments(rq))
Wouldn't it be better to set RQF_SPECIAL_PAYLOAD and friends in
nvme_setup_write_zeroes() like it's done for discard?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-02-20 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 3:11 Regression: NVMe: kernel BUG at lib/sg_pool.c:103! Ming Lei
2019-02-20 3:13 ` Ming Lei
2019-02-20 14:17 ` Christoph Hellwig
2019-02-20 16:59 ` Chaitanya Kulkarni
2019-02-20 18:16 ` Chaitanya Kulkarni
2019-02-20 22:55 ` Martin K. Petersen [this message]
2019-02-21 1:29 ` Chaitanya Kulkarni
2019-02-21 13:37 ` Christoph Hellwig
2019-02-21 14:22 ` Martin K. Petersen
2019-02-21 2:16 ` Ming Lei
2019-02-21 2:21 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tvgyhxyv.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox