From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Kanchan Joshi <joshi.k@samsung.com>,
axboe@kernel.dk, martin.petersen@oracle.com,
linux-block@vger.kernel.org, Anuj Gupta <anuj20.g@samsung.com>
Subject: Re: [PATCH] block: t10-pi: Return correct ref tag when queue has no integrity profile
Date: Thu, 04 Jul 2024 23:49:56 -0400 [thread overview]
Message-ID: <yq1y16g8q1s.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240704063242.GA21732@lst.de> (Christoph Hellwig's message of "Thu, 4 Jul 2024 08:32:42 +0200")
Christoph,
> Looking a bit more it seems like never actually merged the SCSI
> support for an interval_exp smaller than the block size, although I'm
> pretty sure I've seen Martins patches for it. So i guess we should
> just go with this patch (preferably with the fixed Fixes tag and a
> more detailed commit log) and then sort this out later.
The driver for this feature was being able to use disks with 4Kn sectors
and yet provide 8 bytes of PI for every 512 bytes of data for backwards
compatibility reasons.
I had a couple of drives which supported the feature and several OEMs
were requesting it. However, it turned out that using 512e drives was a
much more elegant solution to this particular problem.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-07-05 3:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240704062234epcas5p1dd4ae6e7c91555b9573418d618086c1e@epcas5p1.samsung.com>
2024-07-04 6:15 ` [PATCH] block: t10-pi: Return correct ref tag when queue has no integrity profile Kanchan Joshi
2024-07-04 6:26 ` Christoph Hellwig
2024-07-04 6:32 ` Christoph Hellwig
2024-07-05 3:49 ` Martin K. Petersen [this message]
2024-07-05 5:05 ` Christoph Hellwig
2024-07-05 11:21 ` Martin K. Petersen
2024-07-04 8:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y16g8q1s.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox