From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E017C4361B for ; Tue, 8 Dec 2020 05:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29A1B23A61 for ; Tue, 8 Dec 2020 05:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbgLHF2r (ORCPT ); Tue, 8 Dec 2020 00:28:47 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:47038 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbgLHF2r (ORCPT ); Tue, 8 Dec 2020 00:28:47 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B85PPED160185; Tue, 8 Dec 2020 05:27:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=xu2SOuVwX5VbAcmvGPvHDp156Kjz4OKVWSn9DmmkXsc=; b=rwFh94rx7hPx2pI4RwuVKrtvArJ8B5SOFl0EQ5W6J3pfPa/yy+kzUzV5fB+jF9TS4gYS HADxanSk20cHlvHAsjFP9dL5mkJ4KoPuGiAvvYmSdNkcEdeLt0DjzYKIx4/i50n4wbvj 1q/xfMqlX1lGdCN2Ep3gN9t6huUy8UiS8g7oEwuudafEW3JRofP5q9JIetbdxcg+Y/sh lGakgslKJgotT6VaUq/fYbAsn6MroMmBU8Te52xFxWCBap1BH1e5jMFygzHFqtEtMNSO yJdIugqaRsWdNNpAeiSml/8N3zfBvOv4Rj/SH1i22ExPYJtNpS34RgyM8xJbLUHaDA2p Qw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 357yqbryr7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 08 Dec 2020 05:27:51 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0B85QSmf057815; Tue, 8 Dec 2020 05:27:50 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 358m3x8emb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 Dec 2020 05:27:50 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0B85RoSw019827; Tue, 8 Dec 2020 05:27:50 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 Dec 2020 21:27:43 -0800 To: Christoph Hellwig Cc: Jens Axboe , "Martin K . Petersen" , Oleksii Kurochko , Sagi Grimberg , Mike Snitzer , Ilya Dryomov , Dongsheng Yang , ceph-devel@vger.kernel.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 4/6] block: propagate BLKROSET on the whole device to all partitions From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201207131918.2252553-1-hch@lst.de> <20201207131918.2252553-5-hch@lst.de> Date: Tue, 08 Dec 2020 00:27:41 -0500 In-Reply-To: <20201207131918.2252553-5-hch@lst.de> (Christoph Hellwig's message of "Mon, 7 Dec 2020 14:19:16 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=1 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080032 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9828 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 mlxlogscore=999 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080032 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Christoph, > The existing behavior is inconsistent in the sense that doing: > > permits writes. But: > > > > doesn't. > > And a subsequent: Looks like the command line pieces got zapped from the commit description. In any case this fixes the issue for me. My read-only blktests succeed with this change in place. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering