From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, Milan Broz <gmazyland@gmail.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
dm-devel@redhat.com,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] bio-integrity: revert "stop abusing bi_end_io"
Date: Sat, 05 Aug 2017 16:25:47 -0400 [thread overview]
Message-ID: <yq1y3qxdano.fsf@oracle.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1708051038550.25961@file01.intranet.prod.int.rdu2.redhat.com> (Mikulas Patocka's message of "Sat, 5 Aug 2017 10:46:04 -0400 (EDT)")
Mikulas,
> The sector number in the integrity tag must match the physical sector
> number. So, it must be verified at the bottom.
The ref tag seed matches the submitter block number (typically block
layer sector for the top device) and is remapped to and from the LBA by
the SCSI disk driver or HBA firmware.
So the verification is designed to be done by the top level entity that
attaches the protection information to the bio. In this case
bio_integrity_prep().
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-05 20:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 12:27 [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL Milan Broz
2017-08-02 12:55 ` Christoph Hellwig
2017-08-02 13:15 ` Milan Broz
2017-08-02 14:11 ` Martin K. Petersen
2017-08-02 15:24 ` Milan Broz
2017-08-03 14:10 ` [PATCH] bio-integrity: revert "stop abusing bi_end_io" Mikulas Patocka
2017-08-05 13:44 ` Christoph Hellwig
2017-08-05 14:46 ` Mikulas Patocka
2017-08-05 20:25 ` Martin K. Petersen [this message]
2017-08-06 18:49 ` Mikulas Patocka
2017-08-07 15:48 ` Martin K. Petersen
2017-08-08 6:47 ` Milan Broz
2017-08-05 20:19 ` Martin K. Petersen
2017-08-09 14:07 ` Christoph Hellwig
2017-08-06 13:30 ` [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3qxdano.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).