From: "Mat Martineau" <mathewm@codeaurora.org>
To: "'Gustavo F. Padovan'" <gustavo@padovan.org>,
<linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH 2/4] Bluetooth: Fix remote and local txWindow roles on L2CAP
Date: Tue, 16 Mar 2010 10:00:44 -0700 [thread overview]
Message-ID: <000301cac52a$3816ff50$a844fdf0$@org> (raw)
In-Reply-To: <1268699189-2910-2-git-send-email-gustavo@padovan.org>
Gustavo -
> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Gustavo F. Padovan
> Sent: Monday, March 15, 2010 5:26 PM
> To: linux-bluetooth@vger.kernel.org
> Cc: marcel@holtmann.org; gustavo@padovan.org
> Subject: [PATCH 2/4] Bluetooth: Fix remote and local txWindow roles on
> L2CAP
>
> L2CAP was misusing the values of txWindow. Now the remote txWindow is used
> on the acknowledgement of I-frames and the local txWindow on the sending
> of I-frames. It also renames pi->num_to_ack to a better name:
> pi->num_acked.
>
The XMIT state table for ERTM shows that I-Frames are not sent with the
RemWindow-Full condition, so either the previous implementation was correct
or the naming of remote & local txWindow in l2cap.c is opposite of that in
the spec.
Regards,
Mat Martineau
Qualcomm Innovation Center, Inc.,
A member of the Code Aurora Forum
next prev parent reply other threads:[~2010-03-16 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 0:26 [PATCH 1/4] Bluetooth: Add sockopt configuration for txWindow on L2CAP Gustavo F. Padovan
2010-03-16 0:26 ` [PATCH 2/4] Bluetooth: Fix remote and local txWindow roles " Gustavo F. Padovan
2010-03-16 0:26 ` [PATCH 3/4] Bluetooth: Add module parameter for txWindow size " Gustavo F. Padovan
2010-03-16 0:26 ` [PATCH 4/4] Bluetooth: Enable option to configure Max Transmission value via sockopt Gustavo F. Padovan
2010-03-16 17:00 ` Mat Martineau [this message]
2010-03-16 18:50 ` [PATCH 2/4] Bluetooth: Fix remote and local txWindow roles on L2CAP Gustavo F. Padovan
2010-03-16 15:15 ` [PATCH 1/4] Bluetooth: Add sockopt configuration for txWindow " Mat Martineau
2010-03-16 15:30 ` Gustavo F. Padovan
2010-03-16 16:26 ` Mat Martineau
2010-03-16 16:45 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301cac52a$3816ff50$a844fdf0$@org' \
--to=mathewm@codeaurora.org \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).