From: Gowtham Anandha Babu <gowtham.ab@samsung.com>
To: 'Andrei Emeltchenko' <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: RE: [RFC] monitor: Fix RFCOMM parity type mask
Date: Fri, 05 Dec 2014 16:12:03 +0530 [thread overview]
Message-ID: <000401d01078$1ea58bb0$5bf0a310$@samsung.com> (raw)
In-Reply-To: <1417772907-31708-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Andrei Emeltchenko
> Sent: Friday, December 05, 2014 3:18 PM
> To: linux-bluetooth@vger.kernel.org
> Subject: [RFC] monitor: Fix RFCOMM parity type mask
>
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> monitor/rfcomm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c index fe3afb7..71a2792
> 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -67,7 +67,7 @@ static char *cr_str[] = {
> #define GET_RPN_DB(parity) (parity & 0x03)
> #define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
> #define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
> -#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
> +#define GET_RPN_PTYPE(parity) ((parity & 0x10) >> 4)
> #define GET_RPN_XIN(io) (io & 0x01)
> #define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
> #define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
I missed it during the implementation. Anyway, the parity type bits are in
BIT5 and BIT6 as per the specification.
So it will be 0x30 instead of 0x10.
Regards,
Gowtham Anandha Babu
prev parent reply other threads:[~2014-12-05 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 9:48 [RFC] monitor: Fix RFCOMM parity type mask Andrei Emeltchenko
2014-12-05 10:42 ` Gowtham Anandha Babu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401d01078$1ea58bb0$5bf0a310$@samsung.com' \
--to=gowtham.ab@samsung.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).