* [RFC] monitor: Fix RFCOMM parity type mask
@ 2014-12-05 9:48 Andrei Emeltchenko
2014-12-05 10:42 ` Gowtham Anandha Babu
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Emeltchenko @ 2014-12-05 9:48 UTC (permalink / raw)
To: linux-bluetooth
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
monitor/rfcomm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c
index fe3afb7..71a2792 100644
--- a/monitor/rfcomm.c
+++ b/monitor/rfcomm.c
@@ -67,7 +67,7 @@ static char *cr_str[] = {
#define GET_RPN_DB(parity) (parity & 0x03)
#define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
#define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
-#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
+#define GET_RPN_PTYPE(parity) ((parity & 0x10) >> 4)
#define GET_RPN_XIN(io) (io & 0x01)
#define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
#define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* RE: [RFC] monitor: Fix RFCOMM parity type mask
2014-12-05 9:48 [RFC] monitor: Fix RFCOMM parity type mask Andrei Emeltchenko
@ 2014-12-05 10:42 ` Gowtham Anandha Babu
0 siblings, 0 replies; 2+ messages in thread
From: Gowtham Anandha Babu @ 2014-12-05 10:42 UTC (permalink / raw)
To: 'Andrei Emeltchenko'; +Cc: linux-bluetooth
Hi Andrei,
> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Andrei Emeltchenko
> Sent: Friday, December 05, 2014 3:18 PM
> To: linux-bluetooth@vger.kernel.org
> Subject: [RFC] monitor: Fix RFCOMM parity type mask
>
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> monitor/rfcomm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c index fe3afb7..71a2792
> 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -67,7 +67,7 @@ static char *cr_str[] = {
> #define GET_RPN_DB(parity) (parity & 0x03)
> #define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
> #define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
> -#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
> +#define GET_RPN_PTYPE(parity) ((parity & 0x10) >> 4)
> #define GET_RPN_XIN(io) (io & 0x01)
> #define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
> #define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at http://vger.kernel.org/majordomo-info.html
I missed it during the implementation. Anyway, the parity type bits are in
BIT5 and BIT6 as per the specification.
So it will be 0x30 instead of 0x10.
Regards,
Gowtham Anandha Babu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-05 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 9:48 [RFC] monitor: Fix RFCOMM parity type mask Andrei Emeltchenko
2014-12-05 10:42 ` Gowtham Anandha Babu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).