From: Gowtham Anandha Babu <gowtham.ab@samsung.com>
To: 'Luiz Augusto von Dentz' <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
'Dmitry Kasatkin' <d.kasatkin@samsung.com>,
'Bharat Panda' <bharat.panda@samsung.com>,
cpgs@samsung.com
Subject: RE: [PATCH v1 7/7] monitor/rfcomm: Add rfcomm file in Android.mk
Date: Mon, 03 Nov 2014 14:51:09 +0530 [thread overview]
Message-ID: <000e01cff747$99350080$cb9f0180$@samsung.com> (raw)
In-Reply-To: <CABBYNZJOur6QU0rzFQN8qWXC-T0iEBDQ7La9rOdrpb-c0Sz5Vw@mail.gmail.com>
Hi,
> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> Sent: Monday, November 03, 2014 2:35 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> cpgs@samsung.com
> Subject: Re: [PATCH v1 7/7] monitor/rfcomm: Add rfcomm file in Android.mk
>
> Hi,
>
> On Fri, Oct 31, 2014 at 5:08 PM, Gowtham Anandha Babu
> <gowtham.ab@samsung.com> wrote:
> > ---
> > android/Android.mk | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/android/Android.mk b/android/Android.mk index
> > aefe41c..eebd863 100644
> > --- a/android/Android.mk
> > +++ b/android/Android.mk
> > @@ -289,6 +289,7 @@ LOCAL_SRC_FILES := \
> > bluez/monitor/packet.c \
> > bluez/monitor/l2cap.c \
> > bluez/monitor/avctp.c \
> > + bluez/monitor/rfcomm.c \
> > bluez/monitor/uuid.c \
> > bluez/monitor/sdp.c \
> > bluez/monitor/vendor.c \
> > --
> > 1.9.1
>
> Usually we try very hard to avoid breaking the build even within the same
> patch-set, so if possible please squash this change.
>
>
> --
> Luiz Augusto von Dentz
Do you want me to send this one(Android.mk) as a separate patch (out of this patch-set) or merge this one to first patch ?
Regards,
Gowtham Anandha Babu
next prev parent reply other threads:[~2014-11-03 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 15:08 [PATCH v1 0/7] Add support for RFCOMM in btmon Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 1/7] monitor/rfcomm: Add RFCOMM support to btmon Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 2/7] monitor/rfcomm: Add support for RFCOMM commands Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 3/7] monitor/rfcomm: Add support for UIH frame decoding Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 4/7] monitor/rfcomm: Add support for mcc " Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 5/7] monitor/rfcomm: Add handlers for mcc frame type Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 6/7] monitor/rfcomm: Add mcc type handlers code Gowtham Anandha Babu
2014-10-31 15:08 ` [PATCH v1 7/7] monitor/rfcomm: Add rfcomm file in Android.mk Gowtham Anandha Babu
2014-11-03 9:04 ` Luiz Augusto von Dentz
2014-11-03 9:21 ` Gowtham Anandha Babu [this message]
2014-11-03 10:11 ` Luiz Augusto von Dentz
2014-11-03 10:47 ` Gowtham Anandha Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000e01cff747$99350080$cb9f0180$@samsung.com' \
--to=gowtham.ab@samsung.com \
--cc=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=d.kasatkin@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).