[PATCH 0/3] core: Fix ERROR CODES desc as per core_v4.2

[PATCH 0/3] core: Fix ERROR CODES desc as per core_v4.2

[Gowtham Anandha Babu]

Modified the error codes description as per core V4.2, Vol 2, Part D.
Provided fix for checkpatch errors.

Gowtham Anandha Babu (3):
  monitor/packet: Fix ERROR CODES as per core_v4.2
  parser/hci: Fix ERROR CODES as per core_v4.2
  monitor/packet: Fix possbile checkpatch errors

 monitor/packet.c   | 23 ++++++++++++-----------
 tools/parser/hci.c |  6 +++---
 2 files changed, 15 insertions(+), 14 deletions(-)

-- 
1.9.1

[PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Modified the error codes as per core V4.2, Vol 2, Part D.
---
 monitor/packet.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 885c4b1..87b97ad 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -317,9 +317,10 @@ static const struct {
 	{ 0x1b, "SCO Offset Rejected"					},
 	{ 0x1c, "SCO Interval Rejected"					},
 	{ 0x1d, "SCO Air Mode Rejected"					},
-	{ 0x1e, "Invalid LMP Parameters"				},
+	{ 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"	},
 	{ 0x1f, "Unspecified Error"					},
-	{ 0x20, "Unsupported LMP Parameter Value"			},
+	{ 0x20, "Unsupported LMP Parameter Value / "
+		"Unsupported LL Parameter Value"			},
 	{ 0x21, "Role Change Not Allowed"				},
 	{ 0x22, "LMP Response Timeout / LL Response Timeout"		},
 	{ 0x23, "LMP Error Transaction Collision"			},
@@ -346,7 +347,7 @@ static const struct {
 	{ 0x38, "Host Busy - Pairing"					},
 	{ 0x39, "Connection Rejected due to No Suitable Channel Found"	},
 	{ 0x3a, "Controller Busy"					},
-	{ 0x3b, "Unacceptable Connection Interval"			},
+	{ 0x3b, "Unacceptable Connection Parameters"			},
 	{ 0x3c, "Directed Advertising Timeout"				},
 	{ 0x3d, "Connection Terminated due to MIC Failure"		},
 	{ 0x3e, "Connection Failed to be Established"			},
-- 
1.9.1

Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Luiz Augusto von Dentz]

Hi Gowtham,

On Wed, Dec 10, 2014 at 1:46 PM, Gowtham Anandha Babu
<gowtham.ab@samsung.com> wrote:
> Modified the error codes as per core V4.2, Vol 2, Part D.
> ---
>  monitor/packet.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 885c4b1..87b97ad 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -317,9 +317,10 @@ static const struct {
>         { 0x1b, "SCO Offset Rejected"                                   },
>         { 0x1c, "SCO Interval Rejected"                                 },
>         { 0x1d, "SCO Air Mode Rejected"                                 },
> -       { 0x1e, "Invalid LMP Parameters"                                },
> +       { 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"        },
>         { 0x1f, "Unspecified Error"                                     },
> -       { 0x20, "Unsupported LMP Parameter Value"                       },
> +       { 0x20, "Unsupported LMP Parameter Value / "
> +               "Unsupported LL Parameter Value"                        },

Perhaps just having LMP/LL instead of duplicating the whole string is
a better idea, usually the spec would not change a meaning of an error
or is LL LE specific?

>         { 0x21, "Role Change Not Allowed"                               },
>         { 0x22, "LMP Response Timeout / LL Response Timeout"            },
>         { 0x23, "LMP Error Transaction Collision"                       },
> @@ -346,7 +347,7 @@ static const struct {
>         { 0x38, "Host Busy - Pairing"                                   },
>         { 0x39, "Connection Rejected due to No Suitable Channel Found"  },
>         { 0x3a, "Controller Busy"                                       },
> -       { 0x3b, "Unacceptable Connection Interval"                      },
> +       { 0x3b, "Unacceptable Connection Parameters"                    },

This as well need a bit more explanation, when this has changed or
perhaps we got it wrong to begin with?

>         { 0x3c, "Directed Advertising Timeout"                          },
>         { 0x3d, "Connection Terminated due to MIC Failure"              },
>         { 0x3e, "Connection Failed to be Established"                   },
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz

RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Hi Luiz,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> Sent: Thursday, December 11, 2014 5:49 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> cpgs@samsung.com
> Subject: Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2
> 
> Hi Gowtham,
> 
> On Wed, Dec 10, 2014 at 1:46 PM, Gowtham Anandha Babu
> <gowtham.ab@samsung.com> wrote:
> > Modified the error codes as per core V4.2, Vol 2, Part D.
> > ---
> >  monitor/packet.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/monitor/packet.c b/monitor/packet.c index
> > 885c4b1..87b97ad 100644
> > --- a/monitor/packet.c
> > +++ b/monitor/packet.c
> > @@ -317,9 +317,10 @@ static const struct {
> >         { 0x1b, "SCO Offset Rejected"                                   },
> >         { 0x1c, "SCO Interval Rejected"                                 },
> >         { 0x1d, "SCO Air Mode Rejected"                                 },
> > -       { 0x1e, "Invalid LMP Parameters"                                },
> > +       { 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"        },
> >         { 0x1f, "Unspecified Error"                                     },
> > -       { 0x20, "Unsupported LMP Parameter Value"                       },
> > +       { 0x20, "Unsupported LMP Parameter Value / "
> > +               "Unsupported LL Parameter Value"                        },
> 
> Perhaps just having LMP/LL instead of duplicating the whole string is a better
> idea, usually the spec would not change a meaning of an error or is LL LE
> specific?

Here LMP refers to LMP PDU, LL refers to LL control PDU.
I think changing it into LMP/LL is also a good idea.
But, It's safer to follow the specification.
What do you think?

> 
> >         { 0x21, "Role Change Not Allowed"                               },
> >         { 0x22, "LMP Response Timeout / LL Response Timeout"            },
> >         { 0x23, "LMP Error Transaction Collision"                       },
> > @@ -346,7 +347,7 @@ static const struct {
> >         { 0x38, "Host Busy - Pairing"                                   },
> >         { 0x39, "Connection Rejected due to No Suitable Channel Found"  },
> >         { 0x3a, "Controller Busy"                                       },
> > -       { 0x3b, "Unacceptable Connection Interval"                      },
> > +       { 0x3b, "Unacceptable Connection Parameters"                    },
> 
> This as well need a bit more explanation, when this has changed or perhaps
> we got it wrong to begin with?

It is mentioned in (Errata ID: 5660).
https://www.bluetooth.org/errata/errata_view.cfm?errata_id=5660 (Requires Login).

Description of that errata:
The title of 2.56 is "Unacceptable Connection Parameters (0x3B)".

However, the text begins "The Unacceptable Connection IntervalParameters error code" (sic). HCI 7.1.6 (Disconnect Command) refers to "Unacceptable Connection Interval error code (0x3B)". Volume 6 has two references to "error code 0x3B (Unacceptable Connection Parameters)".

I propose we change the text of 2.56 and of 7.16 to "Unacceptable Connection Parameters".

> 
> >         { 0x3c, "Directed Advertising Timeout"                          },
> >         { 0x3d, "Connection Terminated due to MIC Failure"              },
> >         { 0x3e, "Connection Failed to be Established"                   },
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-bluetooth" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 
> --
> Luiz Augusto von Dentz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html


Regards,
Gowtham Anandha Babu

RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Hi Luiz,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> Sent: Monday, December 15, 2014 6:43 PM
> To: 'Luiz Augusto von Dentz'
> Cc: linux-bluetooth@vger.kernel.org; 'Dmitry Kasatkin'; 'Bharat Panda';
> cpgs@samsung.com
> Subject: RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2
> 
> Hi Luiz,
> 
> > -----Original Message-----
> > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> > owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> > Sent: Thursday, December 11, 2014 5:49 PM
> > To: Gowtham Anandha Babu
> > Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> > cpgs@samsung.com
> > Subject: Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per
> > core_v4.2
> >
> > Hi Gowtham,
> >
> > On Wed, Dec 10, 2014 at 1:46 PM, Gowtham Anandha Babu
> > <gowtham.ab@samsung.com> wrote:
> > > Modified the error codes as per core V4.2, Vol 2, Part D.
> > > ---
> > >  monitor/packet.c | 7 ++++---
> > >  1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/monitor/packet.c b/monitor/packet.c index
> > > 885c4b1..87b97ad 100644
> > > --- a/monitor/packet.c
> > > +++ b/monitor/packet.c
> > > @@ -317,9 +317,10 @@ static const struct {
> > >         { 0x1b, "SCO Offset Rejected"                                   },
> > >         { 0x1c, "SCO Interval Rejected"                                 },
> > >         { 0x1d, "SCO Air Mode Rejected"                                 },
> > > -       { 0x1e, "Invalid LMP Parameters"                                },
> > > +       { 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"        },
> > >         { 0x1f, "Unspecified Error"                                     },
> > > -       { 0x20, "Unsupported LMP Parameter Value"                       },
> > > +       { 0x20, "Unsupported LMP Parameter Value / "
> > > +               "Unsupported LL Parameter Value"                        },
> >
> > Perhaps just having LMP/LL instead of duplicating the whole string is
> > a better idea, usually the spec would not change a meaning of an error
> > or is LL LE specific?
> 
> Here LMP refers to LMP PDU, LL refers to LL control PDU.
> I think changing it into LMP/LL is also a good idea.
> But, It's safer to follow the specification.
> What do you think?
> 
> >
> > >         { 0x21, "Role Change Not Allowed"                               },
> > >         { 0x22, "LMP Response Timeout / LL Response Timeout"            },
> > >         { 0x23, "LMP Error Transaction Collision"                       },
> > > @@ -346,7 +347,7 @@ static const struct {
> > >         { 0x38, "Host Busy - Pairing"                                   },
> > >         { 0x39, "Connection Rejected due to No Suitable Channel Found"  },
> > >         { 0x3a, "Controller Busy"                                       },
> > > -       { 0x3b, "Unacceptable Connection Interval"                      },
> > > +       { 0x3b, "Unacceptable Connection Parameters"                    },
> >
> > This as well need a bit more explanation, when this has changed or
> > perhaps we got it wrong to begin with?
> 
> It is mentioned in (Errata ID: 5660).
> https://www.bluetooth.org/errata/errata_view.cfm?errata_id=5660
> (Requires Login).
> 
> Description of that errata:
> The title of 2.56 is "Unacceptable Connection Parameters (0x3B)".
> 
> However, the text begins "The Unacceptable Connection IntervalParameters
> error code" (sic). HCI 7.1.6 (Disconnect Command) refers to "Unacceptable
> Connection Interval error code (0x3B)". Volume 6 has two references to
> "error code 0x3B (Unacceptable Connection Parameters)".
> 
> I propose we change the text of 2.56 and of 7.16 to "Unacceptable
> Connection Parameters".

Please let me know, if you need more details.

> 
> >
> > >         { 0x3c, "Directed Advertising Timeout"                          },
> > >         { 0x3d, "Connection Terminated due to MIC Failure"              },
> > >         { 0x3e, "Connection Failed to be Established"                   },
> > > --
> > > 1.9.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > > linux-bluetooth" in the body of a message to
> > > majordomo@vger.kernel.org More majordomo info at
> > > http://vger.kernel.org/majordomo-info.html
> >
> >
> >
> > --
> > Luiz Augusto von Dentz
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-bluetooth" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> Regards,
> Gowtham Anandha Babu
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html

Regards,
Gowtham Anandha Babu

RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Ping.

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> Sent: Wednesday, December 17, 2014 11:55 AM
> To: 'Luiz Augusto von Dentz'
> Cc: linux-bluetooth@vger.kernel.org; 'Dmitry Kasatkin'; 'Bharat Panda';
> cpgs@samsung.com
> Subject: RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2
> 
> Hi Luiz,
> 
> > -----Original Message-----
> > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> > owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> > Sent: Monday, December 15, 2014 6:43 PM
> > To: 'Luiz Augusto von Dentz'
> > Cc: linux-bluetooth@vger.kernel.org; 'Dmitry Kasatkin'; 'Bharat
> > Panda'; cpgs@samsung.com
> > Subject: RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per
> > core_v4.2
> >
> > Hi Luiz,
> >
> > > -----Original Message-----
> > > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> > > owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> > > Sent: Thursday, December 11, 2014 5:49 PM
> > > To: Gowtham Anandha Babu
> > > Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> > > cpgs@samsung.com
> > > Subject: Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per
> > > core_v4.2
> > >
> > > Hi Gowtham,
> > >
> > > On Wed, Dec 10, 2014 at 1:46 PM, Gowtham Anandha Babu
> > > <gowtham.ab@samsung.com> wrote:
> > > > Modified the error codes as per core V4.2, Vol 2, Part D.
> > > > ---
> > > >  monitor/packet.c | 7 ++++---
> > > >  1 file changed, 4 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/monitor/packet.c b/monitor/packet.c index
> > > > 885c4b1..87b97ad 100644
> > > > --- a/monitor/packet.c
> > > > +++ b/monitor/packet.c
> > > > @@ -317,9 +317,10 @@ static const struct {
> > > >         { 0x1b, "SCO Offset Rejected"                                   },
> > > >         { 0x1c, "SCO Interval Rejected"                                 },
> > > >         { 0x1d, "SCO Air Mode Rejected"                                 },
> > > > -       { 0x1e, "Invalid LMP Parameters"                                },
> > > > +       { 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"        },
> > > >         { 0x1f, "Unspecified Error"                                     },
> > > > -       { 0x20, "Unsupported LMP Parameter Value"                       },
> > > > +       { 0x20, "Unsupported LMP Parameter Value / "
> > > > +               "Unsupported LL Parameter Value"                        },
> > >
> > > Perhaps just having LMP/LL instead of duplicating the whole string
> > > is a better idea, usually the spec would not change a meaning of an
> > > error or is LL LE specific?
> >
> > Here LMP refers to LMP PDU, LL refers to LL control PDU.
> > I think changing it into LMP/LL is also a good idea.
> > But, It's safer to follow the specification.
> > What do you think?
> >
> > >
> > > >         { 0x21, "Role Change Not Allowed"                               },
> > > >         { 0x22, "LMP Response Timeout / LL Response Timeout"            },
> > > >         { 0x23, "LMP Error Transaction Collision"                       },
> > > > @@ -346,7 +347,7 @@ static const struct {
> > > >         { 0x38, "Host Busy - Pairing"                                   },
> > > >         { 0x39, "Connection Rejected due to No Suitable Channel Found"  },
> > > >         { 0x3a, "Controller Busy"                                       },
> > > > -       { 0x3b, "Unacceptable Connection Interval"                      },
> > > > +       { 0x3b, "Unacceptable Connection Parameters"                    },
> > >
> > > This as well need a bit more explanation, when this has changed or
> > > perhaps we got it wrong to begin with?
> >
> > It is mentioned in (Errata ID: 5660).
> > https://www.bluetooth.org/errata/errata_view.cfm?errata_id=5660
> > (Requires Login).
> >
> > Description of that errata:
> > The title of 2.56 is "Unacceptable Connection Parameters (0x3B)".
> >
> > However, the text begins "The Unacceptable Connection
> > IntervalParameters error code" (sic). HCI 7.1.6 (Disconnect Command)
> > refers to "Unacceptable Connection Interval error code (0x3B)". Volume
> > 6 has two references to "error code 0x3B (Unacceptable Connection
> Parameters)".
> >
> > I propose we change the text of 2.56 and of 7.16 to "Unacceptable
> > Connection Parameters".
> 
> Please let me know, if you need more details.
> 
> >
> > >
> > > >         { 0x3c, "Directed Advertising Timeout"                          },
> > > >         { 0x3d, "Connection Terminated due to MIC Failure"              },
> > > >         { 0x3e, "Connection Failed to be Established"                   },
> > > > --
> > > > 1.9.1
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe
> > > > linux-bluetooth" in the body of a message to
> > > > majordomo@vger.kernel.org More majordomo info at
> > > > http://vger.kernel.org/majordomo-info.html
> > >
> > >
> > >
> > > --
> > > Luiz Augusto von Dentz
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > > linux-bluetooth" in the body of a message to
> > > majordomo@vger.kernel.org More majordomo info at
> > > http://vger.kernel.org/majordomo-info.html
> >
> >
> > Regards,
> > Gowtham Anandha Babu
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-bluetooth" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Regards,
> Gowtham Anandha Babu
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Ping.

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> Sent: Friday, December 19, 2014 6:46 PM
> To: 'Luiz Augusto von Dentz'
> Cc: linux-bluetooth@vger.kernel.org; 'Dmitry Kasatkin'; 'Bharat Panda';
> cpgs@samsung.com
> Subject: RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2
> 
> Ping.
> 
> > -----Original Message-----
> > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> > owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> > Sent: Wednesday, December 17, 2014 11:55 AM
> > To: 'Luiz Augusto von Dentz'
> > Cc: linux-bluetooth@vger.kernel.org; 'Dmitry Kasatkin'; 'Bharat
> > Panda'; cpgs@samsung.com
> > Subject: RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per
> > core_v4.2
> >
> > Hi Luiz,
> >
> > > -----Original Message-----
> > > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> > > owner@vger.kernel.org] On Behalf Of Gowtham Anandha Babu
> > > Sent: Monday, December 15, 2014 6:43 PM
> > > To: 'Luiz Augusto von Dentz'
> > > Cc: linux-bluetooth@vger.kernel.org; 'Dmitry Kasatkin'; 'Bharat
> > > Panda'; cpgs@samsung.com
> > > Subject: RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per
> > > core_v4.2
> > >
> > > Hi Luiz,
> > >
> > > > -----Original Message-----
> > > > From: linux-bluetooth-owner@vger.kernel.org
> > > > [mailto:linux-bluetooth- owner@vger.kernel.org] On Behalf Of Luiz
> > > > Augusto von Dentz
> > > > Sent: Thursday, December 11, 2014 5:49 PM
> > > > To: Gowtham Anandha Babu
> > > > Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat
> > > > Panda; cpgs@samsung.com
> > > > Subject: Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per
> > > > core_v4.2
> > > >
> > > > Hi Gowtham,
> > > >
> > > > On Wed, Dec 10, 2014 at 1:46 PM, Gowtham Anandha Babu
> > > > <gowtham.ab@samsung.com> wrote:
> > > > > Modified the error codes as per core V4.2, Vol 2, Part D.
> > > > > ---
> > > > >  monitor/packet.c | 7 ++++---
> > > > >  1 file changed, 4 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/monitor/packet.c b/monitor/packet.c index
> > > > > 885c4b1..87b97ad 100644
> > > > > --- a/monitor/packet.c
> > > > > +++ b/monitor/packet.c
> > > > > @@ -317,9 +317,10 @@ static const struct {
> > > > >         { 0x1b, "SCO Offset Rejected"                                   },
> > > > >         { 0x1c, "SCO Interval Rejected"                                 },
> > > > >         { 0x1d, "SCO Air Mode Rejected"                                 },
> > > > > -       { 0x1e, "Invalid LMP Parameters"                                },
> > > > > +       { 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"        },
> > > > >         { 0x1f, "Unspecified Error"                                     },
> > > > > -       { 0x20, "Unsupported LMP Parameter Value"                       },
> > > > > +       { 0x20, "Unsupported LMP Parameter Value / "
> > > > > +               "Unsupported LL Parameter Value"                        },
> > > >
> > > > Perhaps just having LMP/LL instead of duplicating the whole string
> > > > is a better idea, usually the spec would not change a meaning of
> > > > an error or is LL LE specific?
> > >
> > > Here LMP refers to LMP PDU, LL refers to LL control PDU.
> > > I think changing it into LMP/LL is also a good idea.
> > > But, It's safer to follow the specification.
> > > What do you think?
> > >
> > > >
> > > > >         { 0x21, "Role Change Not Allowed"                               },
> > > > >         { 0x22, "LMP Response Timeout / LL Response Timeout"            },
> > > > >         { 0x23, "LMP Error Transaction Collision"                       },
> > > > > @@ -346,7 +347,7 @@ static const struct {
> > > > >         { 0x38, "Host Busy - Pairing"                                   },
> > > > >         { 0x39, "Connection Rejected due to No Suitable Channel Found"
> },
> > > > >         { 0x3a, "Controller Busy"                                       },
> > > > > -       { 0x3b, "Unacceptable Connection Interval"                      },
> > > > > +       { 0x3b, "Unacceptable Connection Parameters"                    },
> > > >
> > > > This as well need a bit more explanation, when this has changed or
> > > > perhaps we got it wrong to begin with?
> > >
> > > It is mentioned in (Errata ID: 5660).
> > > https://www.bluetooth.org/errata/errata_view.cfm?errata_id=5660
> > > (Requires Login).
> > >
> > > Description of that errata:
> > > The title of 2.56 is "Unacceptable Connection Parameters (0x3B)".
> > >
> > > However, the text begins "The Unacceptable Connection
> > > IntervalParameters error code" (sic). HCI 7.1.6 (Disconnect Command)
> > > refers to "Unacceptable Connection Interval error code (0x3B)".
> > > Volume
> > > 6 has two references to "error code 0x3B (Unacceptable Connection
> > Parameters)".
> > >
> > > I propose we change the text of 2.56 and of 7.16 to "Unacceptable
> > > Connection Parameters".
> >
> > Please let me know, if you need more details.
> >
> > >
> > > >
> > > > >         { 0x3c, "Directed Advertising Timeout"                          },
> > > > >         { 0x3d, "Connection Terminated due to MIC Failure"              },
> > > > >         { 0x3e, "Connection Failed to be Established"                   },
> > > > > --
> > > > > 1.9.1
> > > > >
> > > > > --
> > > > > To unsubscribe from this list: send the line "unsubscribe
> > > > > linux-bluetooth" in the body of a message to
> > > > > majordomo@vger.kernel.org More majordomo info at
> > > > > http://vger.kernel.org/majordomo-info.html
> > > >
> > > >
> > > >
> > > > --
> > > > Luiz Augusto von Dentz
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe
> > > > linux-bluetooth" in the body of a message to
> > > > majordomo@vger.kernel.org More majordomo info at
> > > > http://vger.kernel.org/majordomo-info.html
> > >
> > >
> > > Regards,
> > > Gowtham Anandha Babu
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > > linux-bluetooth" in the body of a message to
> > > majordomo@vger.kernel.org More majordomo info at
> > > http://vger.kernel.org/majordomo-info.html
> >
> > Regards,
> > Gowtham Anandha Babu
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-bluetooth" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Luiz Augusto von Dentz]

Hi Gowtham,

On Thu, Jan 8, 2015 at 8:21 AM, Gowtham Anandha Babu
<gowtham.ab@samsung.com> wrote:
> Ping.

Could you please resend this set.

RE: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Hi Luiz,

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Luiz Augusto von Dentz
> Sent: Monday, January 12, 2015 5:35 PM
> To: Gowtham Anandha Babu
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin; Bharat Panda;
> cpgs@samsung.com
> Subject: Re: [PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2
> 
> Hi Gowtham,
> 
> On Thu, Jan 8, 2015 at 8:21 AM, Gowtham Anandha Babu
> <gowtham.ab@samsung.com> wrote:
> > Ping.
> 
> Could you please resend this set.

I have just resent this patch set.

Regards,
Gowtham Anandha Babu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] parser/hci: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Modified the error codes as per core V4.2, Vol 2, Part D.
---
 tools/parser/hci.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/parser/hci.c b/tools/parser/hci.c
index cd52cb5..33df542 100644
--- a/tools/parser/hci.c
+++ b/tools/parser/hci.c
@@ -446,9 +446,9 @@ static char *error_code_str[ERROR_CODE_NUM + 1] = {
 	"SCO Offset Rejected",
 	"SCO Interval Rejected",
 	"SCO Air Mode Rejected",
-	"Invalid LMP Parameters",
+	"Invalid LMP Parameters / Invalid LL Parameters",
 	"Unspecified Error",
-	"Unsupported LMP Parameter Value",
+	"Unsupported LMP Parameter Value / Unsupported LL Parameter Value",
 	"Role Change Not Allowed",
 	"LMP Response Timeout",
 	"LMP Error Transaction Collision",
@@ -475,7 +475,7 @@ static char *error_code_str[ERROR_CODE_NUM + 1] = {
 	"Host Busy - Pairing",
 	"Connection Rejected due to No Suitable Channel Found",
 	"Controller Busy",
-	"Unacceptable Connection Interval",
+	"Unacceptable Connection Parameters",
 	"Directed Advertising Timeout",
 	"Connection Terminated Due to MIC Failure",
 	"Connection Failed to be Established",
-- 
1.9.1

[PATCH 3/3] monitor/packet: Fix possbile checkpatch errors

[Gowtham Anandha Babu]

---
 monitor/packet.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 87b97ad..ebff682 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -1052,7 +1052,7 @@ static void print_voice_setting(uint16_t setting)
 		str = "Linear";
 		break;
 	case 0x01:
-		str ="u-law";
+		str = "u-law";
 		break;
 	case 0x02:
 		str = "A-law";
@@ -1096,7 +1096,7 @@ static void print_voice_setting(uint16_t setting)
 		str = "CVSD";
 		break;
 	case 0x01:
-		str ="u-law";
+		str = "u-law";
 		break;
 	case 0x02:
 		str = "A-law";
@@ -2184,7 +2184,7 @@ static void print_channel_map(const uint8_t *map)
 
 			if (count > 1) {
 				print_field("  Channel %u-%u",
-						start, start + count - 1 );
+						start, start + count - 1);
 				count = 0;
 			} else if (count > 0) {
 				print_field("  Channel %u", start);
@@ -2575,7 +2575,7 @@ static const struct {
 					LE_STATE_MASTER_SLAVE	},
 	{ 39, LE_STATE_CONN_SLAVE | LE_STATE_HIGH_DIRECT_ADV |
 					LE_STATE_SLAVE_SLAVE	},
-	{ 40, LE_STATE_CONN_SLAVE| LE_STATE_LOW_DIRECT_ADV |
+	{ 40, LE_STATE_CONN_SLAVE | LE_STATE_LOW_DIRECT_ADV |
 					LE_STATE_SLAVE_SLAVE	},
 	{ 41, LE_STATE_INITIATING | LE_STATE_CONN_SLAVE |
 					LE_STATE_MASTER_SLAVE	},
@@ -2643,7 +2643,7 @@ static void print_le_channel_map(const uint8_t *map)
 
 			if (count > 1) {
 				print_field("  Channel %u-%u",
-						start, start + count - 1 );
+						start, start + count - 1);
 				count = 0;
 			} else if (count > 0) {
 				print_field("  Channel %u", start);
@@ -3900,7 +3900,7 @@ static void create_logic_link_cmd(const void *data, uint8_t size)
 
 static void accept_logic_link_cmd(const void *data, uint8_t size)
 {
-        const struct bt_hci_cmd_accept_logic_link *cmd = data;
+	const struct bt_hci_cmd_accept_logic_link *cmd = data;
 
 	print_phy_handle(cmd->phy_handle);
 	print_flow_spec("TX", cmd->tx_flow_spec);
@@ -3924,7 +3924,7 @@ static void logic_link_cancel_cmd(const void *data, uint8_t size)
 
 static void logic_link_cancel_rsp(const void *data, uint8_t size)
 {
-        const struct bt_hci_rsp_logic_link_cancel *rsp = data;
+	const struct bt_hci_rsp_logic_link_cancel *rsp = data;
 
 	print_status(rsp->status);
 	print_phy_handle(rsp->phy_handle);
@@ -8039,7 +8039,7 @@ void packet_hci_event(struct timeval *tv, uint16_t index,
 	sprintf(extra_str, "(0x%2.2x) plen %d", hdr->evt, hdr->plen);
 
 	print_packet(tv, index, '>', event_color, "HCI Event",
-                                                        event_str, extra_str);
+						event_str, extra_str);
 
 	if (!event_data || !event_data->func) {
 		packet_hexdump(data, size);
-- 
1.9.1

[PATCH 0/3] core: Fix ERROR CODES desc as per core_v4.2

[Gowtham Anandha Babu]

Modified the error codes description as per core V4.2, Vol 2, Part D.
Provided fix for checkpatch errors.

Gowtham Anandha Babu (3):
  monitor/packet: Fix ERROR CODES as per core_v4.2
  parser/hci: Fix ERROR CODES as per core_v4.2
  monitor/packet: Fix possbile checkpatch errors

 monitor/packet.c   | 23 ++++++++++++-----------
 tools/parser/hci.c |  6 +++---
 2 files changed, 15 insertions(+), 14 deletions(-)

-- 
1.9.1

[PATCH 1/3] monitor/packet: Fix ERROR CODES as per core_v4.2

[Gowtham Anandha Babu]

Modified the error codes as per core V4.2, Vol 2, Part D.
---
 monitor/packet.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 885c4b1..87b97ad 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -317,9 +317,10 @@ static const struct {
 	{ 0x1b, "SCO Offset Rejected"					},
 	{ 0x1c, "SCO Interval Rejected"					},
 	{ 0x1d, "SCO Air Mode Rejected"					},
-	{ 0x1e, "Invalid LMP Parameters"				},
+	{ 0x1e, "Invalid LMP Parameters / Invalid LL Parameters"	},
 	{ 0x1f, "Unspecified Error"					},
-	{ 0x20, "Unsupported LMP Parameter Value"			},
+	{ 0x20, "Unsupported LMP Parameter Value / "
+		"Unsupported LL Parameter Value"			},
 	{ 0x21, "Role Change Not Allowed"				},
 	{ 0x22, "LMP Response Timeout / LL Response Timeout"		},
 	{ 0x23, "LMP Error Transaction Collision"			},
@@ -346,7 +347,7 @@ static const struct {
 	{ 0x38, "Host Busy - Pairing"					},
 	{ 0x39, "Connection Rejected due to No Suitable Channel Found"	},
 	{ 0x3a, "Controller Busy"					},
-	{ 0x3b, "Unacceptable Connection Interval"			},
+	{ 0x3b, "Unacceptable Connection Parameters"			},
 	{ 0x3c, "Directed Advertising Timeout"				},
 	{ 0x3d, "Connection Terminated due to MIC Failure"		},
 	{ 0x3e, "Connection Failed to be Established"			},
-- 
1.9.1