From: Vikrampal <vikram.pal@samsung.com>
To: 'Luiz Augusto von Dentz' <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
'Dmitry Kasatkin' <d.kasatkin@samsung.com>
Subject: RE: AVCTP and AVRCP packet decoder file structure in btmon
Date: Tue, 05 Aug 2014 12:24:44 +0530 [thread overview]
Message-ID: <002f01cfb07a$2502c170$6f084450$@samsung.com> (raw)
In-Reply-To: <CABBYNZKfvD271JoWqCW=Lupu-22scZRAJ0D8ksG8bXfUP8gBkg@mail.gmail.com>
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches
Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that
the patches separately compiles. What we need to ensure is that all the patches together
gets compiled properly. Am I mistaken?
> -----Original Message-----
> From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com]
> Sent: Monday, August 04, 2014 4:15 PM
> To: Vikrampal
> Cc: linux-bluetooth@vger.kernel.org; Dmitry Kasatkin
> Subject: Re: AVCTP and AVRCP packet decoder file structure in btmon
>
> Hi Vikrampal,
>
> We can start by reusing avctp.c to place AV/C and AVRCP decoders, later on
> we can review if it is the case of splitting. Also please note that
> android/Android.mk needs updating if we change anything on the build of
> btmon.
>
> On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal <vikram.pal@samsung.com>
> wrote:
> > Hi,
> >
> > I'm working on AVRCP packet decoder for Bluetooth monitor module.
> > There's a separate file avctp.c/h for AVCTP packet decoder.
> >
> > The file avctp.c is not a big file as such. So, I'm thinking whether
> > or not I should include AVRCP decoder in this file itself.
> >
> > Shall I create a separate file for AVRCP decoding?
> >
> > If both AVCTP & AVRCP go in the same file then what should be the
> > appropriate name of the file or shall I create a separate file for
> > AVRCP as well.
> >
> > Please advise me. Thanks!
> >
> > Regards,
> > Vikram
> >
>
>
>
> --
> Luiz Augusto von Dentz
Regards,
Vikram
next prev parent reply other threads:[~2014-08-05 6:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 8:48 AVCTP and AVRCP packet decoder file structure in btmon Vikrampal
2014-08-04 10:45 ` Luiz Augusto von Dentz
2014-08-05 6:54 ` Vikrampal [this message]
2014-08-05 8:01 ` Luiz Augusto von Dentz
2014-08-05 9:12 ` Vikrampal
2014-08-05 9:13 ` Vikrampal
2014-08-05 11:51 ` Antonio Ospite
2014-08-06 8:18 ` Vikrampal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002f01cfb07a$2502c170$6f084450$@samsung.com' \
--to=vikram.pal@samsung.com \
--cc=d.kasatkin@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).