From: "Peter Krystad" <pkrystad@codeaurora.org>
To: "'Andrei Emeltchenko'" <andrei.emeltchenko.news@gmail.com>
Cc: <linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH v3 bluez 2/2] Add A2MP definitions
Date: Thu, 17 Nov 2011 11:05:51 -0800 [thread overview]
Message-ID: <006301cca55b$ec7f6280$c57e2780$@org> (raw)
In-Reply-To: <20111117094539.GC415@aemeltch-MOBL1>
Hi Andrei,
> > +
> > +/* AMP controller type */
> > +#define AMP_CTRL_BR_EDR 0x00
> > +#define AMP_CTRL_802_11 0x01
>
> Do we need to define those values? Cannot you use already defined ones in
> hci.h?
You're right, I'll remove them.
> in include/net/bluetooth/hci.h and lib/hci.h
> /* HCI controller types */
> #define HCI_BREDR 0x00
> #define HCI_AMP 0x01
>
> Maybe HCI_AMP is not the best way and at some point we might need to
> rename it according to BT Spec assigned numbers (like HCI_AMP_802_11)
Agreed it should be changed to reflect 802.11.
> Otherwise
>
> Acked-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Regards,
Peter.
--Peter Krystad
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
next prev parent reply other threads:[~2011-11-17 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 4:25 [PATCH v3 bluez 2/2] Add A2MP definitions Peter Krystad
2011-11-17 9:26 ` Johan Hedberg
2011-11-17 18:19 ` Peter Krystad
2011-11-18 5:15 ` Marcel Holtmann
2011-11-17 9:45 ` Andrei Emeltchenko
2011-11-17 19:05 ` Peter Krystad [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-03 0:36 [PATCH v3 bluez 0/2] Add BT 3.0+HS definitions Peter Krystad
2011-11-03 0:36 ` [PATCH v3 bluez 2/2] Add A2MP definitions Peter Krystad
2011-12-12 10:42 ` Johan Hedberg
2011-12-12 12:28 ` Andrei Emeltchenko
2011-12-13 1:01 ` Peter Krystad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006301cca55b$ec7f6280$c57e2780$@org' \
--to=pkrystad@codeaurora.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).