From: Bharat Bhusan Panda <bharat.panda@samsung.com>
To: linux-bluetooth@vger.kernel.org
Cc: cpgs@samsung.com
Subject: RE: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
Date: Fri, 19 Jun 2015 15:15:28 +0530 [thread overview]
Message-ID: <011401d0aa74$b1661550$14323ff0$@samsung.com> (raw)
In-Reply-To:
ping
> -----Original Message-----
> From: Bharat Bhusan Panda [mailto:bharat.panda@samsung.com]
> Sent: Thursday, June 11, 2015 11:14 AM
> To: 'linux-bluetooth@vger.kernel.org'
> Cc: 'cpgs@samsung.com'
> Subject: RE: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
>
> ping
>
> > -----Original Message-----
> > From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> > owner@vger.kernel.org] On Behalf Of Bharat Panda
> > Sent: Friday, June 05, 2015 8:44 PM
> > To: linux-bluetooth@vger.kernel.org
> > Cc: cpgs@samsung.com; Bharat Panda
> > Subject: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
> >
> > Total Number of Tracks was not displayed, coz "Number of Tracks"
> > was not handled in metadata parser.
> > ---
> > profiles/audio/media.c | 3 +++
> > tools/mpris-proxy.c | 3 +++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/profiles/audio/media.c b/profiles/audio/media.c index
> > f12569e..8e7e1a3 100644
> > --- a/profiles/audio/media.c
> > +++ b/profiles/audio/media.c
> > @@ -1510,6 +1510,9 @@ static gboolean parse_player_metadata(struct
> > media_player *mp,
> > } else if (strcasecmp(key, "xesam:trackNumber") == 0) {
> > if (!parse_int32_metadata(mp, "TrackNumber",
> > &var))
> > return FALSE;
> > + } else if (strcasecmp(key, "xesam:totalTracks") == 0) {
> > + if (!parse_int32_metadata(mp, "NumberOfTracks",
> > &var))
> > + return FALSE;
> > } else
> > DBG("%s not supported, ignoring", key);
> >
> > diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c index
> > 693055e..5749427
> > 100644
> > --- a/tools/mpris-proxy.c
> > +++ b/tools/mpris-proxy.c
> > @@ -1261,6 +1261,9 @@ static int parse_track_entry(DBusMessageIter
> > *entry, const char *key,
> > } else if (strcasecmp(key, "TrackNumber") == 0) {
> > if (!parse_int32_metadata(&var, "xesam:trackNumber",
> > metadata))
> > return -EINVAL;
> > + } else if (strcasecmp(key, "NumberOfTracks") == 0) {
> > + if (!parse_int32_metadata(&var, "xesam:totalTracks",
> > metadata))
> > + return -EINVAL;
> > } else if (strcasecmp(key, "Item") == 0) {
> > if (!parse_path_metadata(&var, "mpris:trackid", metadata))
> > return -EINVAL;
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-bluetooth" in the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-19 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 15:13 [PATCH ] AVRCP: Handle Total Number Of Tracks metadata Bharat Panda
2015-06-11 5:44 ` Bharat Bhusan Panda
2015-06-19 9:45 ` Bharat Bhusan Panda [this message]
2015-06-23 8:39 ` Luiz Augusto von Dentz
2015-06-23 11:34 ` Bharat Bhusan Panda
2015-06-23 12:53 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011401d0aa74$b1661550$14323ff0$@samsung.com' \
--to=bharat.panda@samsung.com \
--cc=cpgs@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).