public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: "Gix, Brian" <brian.gix@intel.com>
To: "michal.lowas-rzechonek@silvair.com" 
	<michal.lowas-rzechonek@silvair.com>,
	"Stotland, Inga" <inga.stotland@intel.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: mesh: org.bluez.mesh.Element.MessageReceived method does not provide destination address
Date: Fri, 27 Sep 2019 15:50:02 +0000	[thread overview]
Message-ID: <01c84f55db98fbcc2790d11fd6090589881c36cf.camel@intel.com> (raw)
In-Reply-To: <20190927085208.sxy2x5656ci3opo6@mlowasrzechonek2133>

On Fri, 2019-09-27 at 10:52 +0200, michal.lowas-rzechonek@silvair.com wrote:
> Inga, Brian,
> 
> Still, even if we add a method, the application is free *not* to
> implement it, since we agreed back in the day that calls to
> MessageReceived do not require a response, so any errors would be simply
> ignored by the daemon.

This is not an option.

A node does not get to decide which susbscriptions are "valid".  If a Virtual Address subscription is added to
a node, and then a message is sent to that virtua address, the App needs to be able to receive it.

Yes, any discrete message may be lost, but I don't think we have the option of letting *all* virtual addressed
messages to an App to be ignored.  If we add an App API, it will need to be mandatory, which is why I am
against it.

I strongly believe we need:

1. A single method for delivering (non dev key) received messages
2. A method that does not require dictionary parsing

How are we feeling about:
	void MessageReceived(uint16 source, uint16 key_index,
				array{byte} destination, array{byte} data)


Where destination length of:
	0 - Unicast address of element
	2 - Group Address
	16 - Variable Label

I think this fulfills all of our requirements.








  parent reply	other threads:[~2019-09-27 15:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 18:43 mesh: org.bluez.mesh.Element.MessageReceived method does not provide destination address Michał Lowas-Rzechonek
2019-09-04 19:25 ` Michał Lowas-Rzechonek
2019-09-04 19:48   ` Michał Lowas-Rzechonek
2019-09-04 20:26     ` Gix, Brian
2019-09-04 22:39       ` Stotland, Inga
2019-09-05  7:29         ` michal.lowas-rzechonek
2019-09-05  7:34       ` michal.lowas-rzechonek
2019-09-18  8:52 ` Michał Lowas-Rzechonek
2019-09-18 12:36   ` Michał Lowas-Rzechonek
2019-09-25 19:02   ` Stotland, Inga
2019-09-26 15:18     ` Gix, Brian
2019-09-26 20:41       ` Stotland, Inga
2019-09-26 23:48         ` Gix, Brian
2019-09-27  2:54           ` Stotland, Inga
2019-09-27  8:52         ` michal.lowas-rzechonek
2019-09-27 15:01           ` Gix, Brian
2019-09-27 15:50           ` Gix, Brian [this message]
2019-09-27 17:25             ` Stotland, Inga
2019-09-27 19:25               ` Gix, Brian
2019-09-30  7:18                 ` michal.lowas-rzechonek
2019-09-30 16:34                   ` Stotland, Inga
2019-09-30 17:57                   ` Gix, Brian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01c84f55db98fbcc2790d11fd6090589881c36cf.camel@intel.com \
    --to=brian.gix@intel.com \
    --cc=inga.stotland@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=michal.lowas-rzechonek@silvair.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox