RE: [PATCH v2] monitor: Add AVDTP support to btmon

[Bharat Bhusan Panda <bharat.panda@samsung.com>]

Hi Luiz,

> >> +
> >> +void avdtp_packet(const struct l2cap_frame *frame) {
> >> +     struct l2cap_frame *l2cap_frame;
> >> +     struct avdtp_frame avdtp_frame;
> >> +     const char *pdu_color;
> >> +
> >> +     l2cap_frame_pull(&avdtp_frame.l2cap_frame, frame, 0);
> >> +
> >> +     l2cap_frame = &avdtp_frame.l2cap_frame;
> >> +
> >> +     avdtp_frame.tsid = 0x00;
> >> +     if (!l2cap_frame_get_u8(l2cap_frame, &avdtp_frame.hdr) ||
> >> +                     !l2cap_frame_get_u8(l2cap_frame,
> >> &avdtp_frame.tsid)) {
> >> +             print_text(COLOR_ERROR, "frame too short");
> >> +             packet_hexdump(frame->data, frame->size);
> >> +             return;
> >> +     }
> 
> It looks like you are treating all frames as signalling but A2DP uses the same
> PSM for streaming so I wonder if you have tried this with an active stream?
Yes, I was testing it through mecApp, so couldn't test the real media streaming of the same.
I agree, it is treating all frames as signaling frames, which is how it should not be. I will submit another version for this patch handling the same.
> 

Thanks
Best Regards,
Bharat