From: Marcel Holtmann <marcel@holtmann.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jeremy Cline <jeremy@jcline.org>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
linux-serial@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Make BT_HCIUART_RTL configuration option depend on ACPI
Date: Tue, 14 Aug 2018 12:36:09 +0200 [thread overview]
Message-ID: <023F3FC8-EE26-444E-BA0F-4F50317A7530@holtmann.org> (raw)
In-Reply-To: <CAK8P3a3QN9oo+vo=aTZGEABj7Q8igWwZh7R+p6vRMKWoK7Hg=A@mail.gmail.com>
Hi Arnd,
>> At the moment we only support ACPI enumeration for serial port attached
>> RTL bluetooth controllers.
>>
>> This commit adds a dependency on ACPI to the BT_HCIUART_RTL configuration
>> option, fixing the following warning when ACPI is not enabled:
>>
>> drivers/bluetooth/hci_h5.c:920:22: warning: 'rtl_vnd' defined but not used
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> This fixes the warning,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I wonder whether CONFIG_BT_HCIUART_3WIRE should also
> depend on ACPI and/or become a silent option, since it's currently
> useless when either ACPI or BT_HCIUART_RTL are disabled,
> and it seems possible that things break differently when another
> back-end gets added there.
why would it be useless? There is still a line discipline mode that it can be used for. Moving this all to the new bt3wire.c driver would have been cleaner and less Kconfig messy.
Regards
Marcel
next prev parent reply other threads:[~2018-08-14 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 9:57 [PATCH] Bluetooth: Make BT_HCIUART_RTL configuration option depend on ACPI Hans de Goede
2018-08-14 10:25 ` Arnd Bergmann
2018-08-14 10:36 ` Marcel Holtmann [this message]
2018-08-14 11:01 ` Arnd Bergmann
2018-08-20 20:54 ` Geert Uytterhoeven
2018-08-21 14:37 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=023F3FC8-EE26-444E-BA0F-4F50317A7530@holtmann.org \
--to=marcel@holtmann.org \
--cc=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=jeremy@jcline.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox