From: "Liu, Raymond" <raymond.liu@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: RE: Can we change org.openobex.Client's dbus node path?
Date: Mon, 24 Nov 2008 18:11:20 +0800 [thread overview]
Message-ID: <0463F45F3606F4428ED35AC8C709F92E021C55AE@pdsmsx502.ccr.corp.intel.com> (raw)
In-Reply-To: <D964A4DB-60BA-4B95-A970-4D7E3E289670@holtmann.org>
>
>so first, please fix the coding style here. I can tell from just the
>pure email that you are mixing up tabs and spaces and also that you
>are missing whitespaces here and there. Check that your mail client
>doesn't mangle it. If in doubt send it as attachment.
>
>Regards
>
>Marcel
Hi Marcel
Thanks for point out the tabs and spaces issue, I think this is might be re=
lated to my terminal setting when I do the copy/paste with the diff output.=
And 3 whitespaces added. So here it is:
---------------------------------------------------------------------------
diff --git a/gdbus/object.c b/gdbus/object.c
index a417ab9..9cf6f09 100644
--- a/gdbus/object.c
+++ b/gdbus/object.c
@@ -299,25 +299,28 @@ static void invalidate_parent_data(DBusConnection *co=
nn, const char *child_path)
char *parent_path, *slash;
=20
parent_path =3D g_strdup(child_path);
- slash =3D strrchr(parent_path, '/');
- if (!slash)
- goto done;
-
- *slash =3D '\0';
- if (!strlen(parent_path))
- goto done;
+ do {
+ slash =3D strrchr(parent_path, '/');
+ if (!slash)
+ break;
=20
- if (!dbus_connection_get_object_path_data(conn, parent_path,
- (void *) &data))
- goto done;
+ if (slash =3D=3D parent_path) {
+ *(slash + 1) =3D '\0';
+ } else {
+ *slash =3D '\0';
+ }
=20
- if (!data)
- goto done;
+ if (!dbus_connection_get_object_path_data(conn, parent_path,
+ (void *) &data))
+ continue;
=20
- g_free(data->introspect);
- data->introspect =3D NULL;
+ if (!data)
+ continue;
=20
-done:
+ g_free(data->introspect);
+ data->introspect =3D NULL;
+ } while (slash !=3D parent_path);
+=09
g_free(parent_path);
}
---------------------------------------------
Raymond
prev parent reply other threads:[~2008-11-24 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 2:01 Can we change org.openobex.Client's dbus node path? Liu, Raymond
2008-11-24 2:41 ` Marcel Holtmann
2008-11-24 3:24 ` Liu, Raymond
2008-11-24 3:30 ` Marcel Holtmann
2008-11-24 5:39 ` Liu, Raymond
2008-11-24 5:48 ` Liu, Raymond
2008-11-24 8:29 ` Marcel Holtmann
2008-11-24 10:11 ` Liu, Raymond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0463F45F3606F4428ED35AC8C709F92E021C55AE@pdsmsx502.ccr.corp.intel.com \
--to=raymond.liu@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox