From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: sean.wang@mediatek.com, marcel@holtmann.org,
johan.hedberg@gmail.com, luiz.dentz@gmail.com
Cc: Soul.Huang@mediatek.com, YN.Chen@mediatek.com,
Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com,
Deren.Wu@mediatek.com, km.lin@mediatek.com,
robin.chiu@mediatek.com, Eddie.Chen@mediatek.com,
ch.yeh@mediatek.com, posh.sun@mediatek.com,
ted.huang@mediatek.com, Stella.Chang@mediatek.com,
Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com,
frankgor@google.com, abhishekpandit@google.com,
michaelfsun@google.com, abhishekpandit@chromium.org,
mcchou@chromium.org, shawnku@google.com,
linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] Bluetooth: btusb: mediatek: reset the device as WMT failed
Date: Tue, 13 Sep 2022 09:49:15 +0200 [thread overview]
Message-ID: <07016e51-a5b5-a350-cad2-b9fcebfe3706@collabora.com> (raw)
In-Reply-To: <a432abf4cf95e93783864b27bafa53d45bdd5212.1663020936.git.objelf@gmail.com>
Il 13/09/22 00:18, sean.wang@mediatek.com ha scritto:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Reset the BT device whenever the driver detected any WMT failure happened
> to recover such kind of system-level error as soon as possible.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
This looks like a fix, so you probably want a Fixes tag for backport.
Regards,
Angelo
> ---
> drivers/bluetooth/btusb.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 653f57a98233..dc86726c8271 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2576,6 +2576,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
> data->evt_skb = NULL;
> err_free_wc:
> kfree(wc);
> +
> + if (err < 0)
> + btmtk_reset_sync(hdev);
> +
> return err;
> }
>
next prev parent reply other threads:[~2022-09-13 7:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 22:18 [PATCH 1/4] Bluetooth: btusb: mediatek: use readx_poll_timeout instead of open coding sean.wang
2022-09-12 22:18 ` [PATCH 2/4] Bluetooth: btmtk: introduce btmtk reset work sean.wang
2022-09-12 22:18 ` [PATCH 3/4] Bluetooth: btusb: mediatek: reset the device as WMT failed sean.wang
2022-09-13 7:49 ` AngeloGioacchino Del Regno [this message]
2022-09-14 22:34 ` Sean Wang
2022-09-14 22:45 ` Luiz Augusto von Dentz
2022-09-15 1:57 ` Sean Wang
2022-09-12 22:18 ` [PATCH 4/4] Bluetooth: btusb: mediatek: add MediaTek devcoredump support sean.wang
2022-09-13 6:29 ` kernel test robot
2022-09-13 10:56 ` kernel test robot
2022-09-13 10:56 ` kernel test robot
2022-09-12 23:10 ` [1/4] Bluetooth: btusb: mediatek: use readx_poll_timeout instead of open coding bluez.test.bot
2022-09-13 7:47 ` [PATCH 1/4] " AngeloGioacchino Del Regno
2022-09-14 22:59 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07016e51-a5b5-a350-cad2-b9fcebfe3706@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Deren.Wu@mediatek.com \
--cc=Eddie.Chen@mediatek.com \
--cc=Eric-SY.Chang@mediatek.com \
--cc=Leon.Yen@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=Stella.Chang@mediatek.com \
--cc=Tom.Chou@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=abhishekpandit@chromium.org \
--cc=abhishekpandit@google.com \
--cc=ch.yeh@mediatek.com \
--cc=frankgor@google.com \
--cc=johan.hedberg@gmail.com \
--cc=jsiuda@google.com \
--cc=km.lin@mediatek.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=michaelfsun@google.com \
--cc=posh.sun@mediatek.com \
--cc=robin.chiu@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shawnku@google.com \
--cc=steve.lee@mediatek.com \
--cc=ted.huang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox