Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@rvs.uni-bielefeld.de>
To: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: [Bluez-devel] Reuse of H4 and BCSP code
Date: 25 Nov 2002 22:43:53 +0100	[thread overview]
Message-ID: <1038260639.772.57.camel@pegasus.local> (raw)

Hi,

the current hci_uart.o driver supports H4 and BCSP HCI protocols and the
code from it should be reusable by the other drivers two. For example
most PCMCIA cards are a kind of serial cards with an UART on it. The
only difference is how the UART would be used to talk to the Bluetooth
chips and many times you need some extra code. If this Bluetooth chip is
one from CSR their are two protocols available two use and you can
switch between them if you like (and autodetection would be great). So
it should be possible to reuse the H4 and the BCSP code, which will make
some PCCARD drivers a little bit smaller.

The current driver which can reuse the code are:

bluecard_cs:	H4
bt3c_cs:	H4
btuart_cs:	H4 and BCSP
bt950_cs:	H4 and BCSP
hci_uart:	H4 and BCSP

At the moment I see two ways of doing this, but maybe there are more of
them.

1. Let the hci_uart driver export some function to let the drivers
register. Maybe something like:

	hci_register_uart	(which later calls hci_register_dev)
	hci_unregister_uart	(which later calls hci_unregister_dev)

2. Make the code in hci_h4.c and hci_bcsp.c linkable against the driver.

Both versions have advantages and disadvantages. The first one keeps the
size of the driver module small, but you always need another module to
interface with the HCI core. The second one need no other modules, but
the code for the UART protocols are in every driver.

>From me personal view of it I don't like to have too much modules and I
would go with the second possibility. But anyway for both methods some
parts of the BCSP init code have to be moved to the kernel space.

Please comment on this. Anyone who will start with this?

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T 
handheld. Power & Color in a compact size! 
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

             reply	other threads:[~2002-11-25 21:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-25 21:43 Marcel Holtmann [this message]
2002-11-26 18:02 ` [Bluez-devel] Reuse of H4 and BCSP code Max Krasnyansky
2002-11-27 15:09   ` Marcel Holtmann
2002-11-27 18:34     ` Max Krasnyansky
2002-11-28  6:47       ` Marcel Holtmann
2003-01-15 23:45         ` David Woodhouse
2002-11-28 12:35     ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1038260639.772.57.camel@pegasus.local \
    --to=marcel@rvs.uni-bielefeld.de \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox