Re: [Bluez-devel] L2CAP raw socket patch

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

Hi Collin,

> I have written a small patch for l2cap.c to improve the capabilities of
> L2CAP raw sockets. Currently only very few responses travel back to a
> RAW socket (which is very bad if you need to see command responses).
> The patch is very simple - it just puts all responses on the
> Sig-Channel to all open RAW sockets. The owner of the raw socket just
> needs to select his packets and in normal operation there shouldn't be
> much use of RAW sockets so I don't think this is a performance issue.

do anyone have comments about this patch?

> I have attached the patch file to this email, hope this is ok.

BTW this patch is wrong, because we must keep the case statements.
Otherwise the kernel log will be filled with unneeded error messages.

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 707 bytes --]

diff -urN linux-2.6.2/net/bluetooth/l2cap.c linux-2.6.2-mh/net/bluetooth/l2cap.c
--- linux-2.6.2/net/bluetooth/l2cap.c	2004-02-04 04:44:04.000000000 +0100
+++ linux-2.6.2-mh/net/bluetooth/l2cap.c	2004-02-10 23:04:49.000000000 +0100
@@ -1643,6 +1643,8 @@
 			break;
 		}
 
+		l2cap_raw_recv(conn, skb);
+
 		switch (cmd.code) {
 		case L2CAP_CONN_REQ:
 			err = l2cap_connect_req(conn, &cmd, data);
@@ -1670,7 +1672,6 @@
 
 		case L2CAP_COMMAND_REJ:
 			/* FIXME: We should process this */
-			l2cap_raw_recv(conn, skb);
 			break;
 
 		case L2CAP_ECHO_REQ:
@@ -1680,7 +1681,6 @@
 		case L2CAP_ECHO_RSP:
 		case L2CAP_INFO_REQ:
 		case L2CAP_INFO_RSP:
-			l2cap_raw_recv(conn, skb);
 			break;
 
 		default: